From: "H. Peter Anvin" <hpa@zytor.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Mark early_printk as asmlinkage
Date: Wed, 12 Mar 2008 15:21:15 +0100 [thread overview]
Message-ID: <47D7E6DB.6030709@zytor.com> (raw)
In-Reply-To: <47D7E392.3080807@gmail.com>
Jiri Slaby wrote:
> On 03/12/2008 03:04 PM, H. Peter Anvin wrote:
>> Jiri Slaby wrote:
>>> It's not explicitly marked as asmlinkage, but invoked from x86_32
>>> startup code with parameters on stack.
>>>
>>> No other architectures define early_printk and none of them are affected
>>> by this change, since defines asmlinkage as empty token.
>>
>> NAK.
>>
>> The regparm ABI for x86-32 uses parameters on the stack when the
>> function is varadic (as it is here), so this is unnecessary.
>
> Makes sense. Why is printk marked as asmlinkage?
Hm. Don't know if it's historical, stylistic (anything called from
assembly should have "asmlinkage"), or just based on a misunderstanding
of the regparm ABI.
-hpa
next prev parent reply other threads:[~2008-03-12 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 13:53 [PATCH] Arch: x86_32, fix fault_msg nul termination Jiri Slaby
2008-03-12 13:53 ` [PATCH] Mark early_printk as asmlinkage Jiri Slaby
2008-03-12 14:04 ` H. Peter Anvin
2008-03-12 14:07 ` Jiri Slaby
2008-03-12 14:21 ` H. Peter Anvin [this message]
2008-03-14 18:04 ` Pavel Machek
2008-03-14 18:39 ` H. Peter Anvin
2008-03-21 12:25 ` Ingo Molnar
2008-03-21 11:50 ` [PATCH] Arch: x86_32, fix fault_msg nul termination Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D7E6DB.6030709@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.