From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Christie <michaelc@cs.wisc.edu>
Subject: Re: [PATCH 6/9] fc class: add fc queueing helper
Date: Thu, 13 Mar 2008 10:36:08 -0500
Message-ID: <47D949E8.2030908@cs.wisc.edu>
References: <1204448602-5435-1-git-send-email-michaelc@cs.wisc.edu> <1204448602-5435-2-git-send-email-michaelc@cs.wisc.edu> <1204448602-5435-3-git-send-email-michaelc@cs.wisc.edu> <1204448602-5435-4-git-send-email-michaelc@cs.wisc.edu> <1204448602-5435-5-git-send-email-michaelc@cs.wisc.edu> <1204448602-5435-6-git-send-email-michaelc@cs.wisc.edu> <47D93BAF.8030203@sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-scsi-owner@vger.kernel.org>
Received: from sabe.cs.wisc.edu ([128.105.6.20]:41525 "EHLO sabe.cs.wisc.edu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755214AbYCMPg2 (ORCPT <rfc822;linux-scsi@vger.kernel.org>);
	Thu, 13 Mar 2008 11:36:28 -0400
In-Reply-To: <47D93BAF.8030203@sgi.com>
Sender: linux-scsi-owner@vger.kernel.org
List-Id: linux-scsi@vger.kernel.org
To: Michael Reed <mdr@sgi.com>
Cc: linux-scsi@vger.kernel.org, david.somayajulu@qlogic.com, andrew.vasquez@qlogic.com, James.Smart@Emulex.com, Eric.Moore@lsil.com

Michael Reed wrote:
> 
> michaelc@cs.wisc.edu wrote:
>> From: Mike Christie <michaelc@cs.wisc.edu>
>>
>> Add a queueing helper which will return SCSI_MLQUEUE_TARGET_BUSY
>> if we are transitioning because there is no need to call into
>> the driver anymore at that point.
>>
>> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
>> ---
>>  include/scsi/scsi_transport_fc.h |   33 +++++++++++++++++++++++++++++++++
>>  1 files changed, 33 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/scsi/scsi_transport_fc.h b/include/scsi/scsi_transport_fc.h
>> index 4769efd..62a6a74 100644
>> --- a/include/scsi/scsi_transport_fc.h
>> +++ b/include/scsi/scsi_transport_fc.h
>> @@ -29,6 +29,7 @@
>>  
>>  #include <linux/sched.h>
>>  #include <scsi/scsi.h>
>> +#include <scsi/scsi_cmnd.h>
>>  #include <scsi/scsi_netlink.h>
>>  
>>  struct scsi_transport_template;
>> @@ -640,6 +641,38 @@ struct fc_function_template {
>>  	unsigned long	disable_target_scan:1;
>>  };
>>  
>> +/**
>> + * fc_remote_port_queue_ready - called to validate the remote port state
>> + * @rport: remote port to be checked
>> + *
>> + * Returns 0 if IO can be queued or if there the cmd should be
> 
> Remove "there" from the comment.
> 
>> + * completed by a call to cmd->scsi_done. Caller must check cmd->result.
>> + * Returns SCSI_MLQUEUE value if IO cannot be queued temporarily.
> 
> How 'bout: "Returns a SCSI_MLQUEUE value if the IO cannot be queued due
> to an rport state transition." ?
> 

A lot better :) I will fix that and the iscsi comment too. Thanks.