From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ide: constify struct ide_dma_ops
Date: Thu, 13 Mar 2008 21:44:39 +0300 [thread overview]
Message-ID: <47D97617.1020907@ru.mvista.com> (raw)
In-Reply-To: <200803091702.18521.bzolnier@gmail.com>
Hello.
Bartlomiej Zolnierkiewicz wrote:
> * Export ide_dma_exec_cmd() and __ide_dma_test_irq().
> * Constify struct ide_dma_ops.
> * Always set hwif->dma_ops to &sff_dma_ops in ide_setup_dma()
> (it is later overriden by ide_init_port() if needed) and drop
> 'const struct ide_port_info *d' argument.
> While at it:
> * Rename __ide_dma_test_irq() to __ide_dma_test_irq().
I'd have expected that you also rename __ide_dma_end() to ide_dma_end()...
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2008-03-13 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-09 16:02 [PATCH 4/4] ide: constify struct ide_dma_ops Bartlomiej Zolnierkiewicz
2008-03-09 17:01 ` Sergei Shtylyov
2008-03-10 21:53 ` Bartlomiej Zolnierkiewicz
2008-03-13 18:44 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D97617.1020907@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.