Re: [PATCH 9/9] mptfc: convert mptfc to use fc queueing helper.

[Michael Reed <mdr@sgi.com>]

michaelc@cs.wisc.edu wrote:
> From: Mike Christie <michaelc@cs.wisc.edu>
> 
> Convert mptfc to use fc queueing helper.

I've been trying to exercise the fusion FC change.
I can't seem to force the code into returning either
TARGET_BUSY or DID_NO_CONNECT.  Any suggestions on
how I might get a command down to the driver while
the rport is blocked or in DEVLOSS_PENDING?

I've been running 32 outstanding commands to 16 targets,
disabling/enabling the various FC switch ports, AND
I disabled the usage of the scsi_host_lock in
fc_remote_port_delete() and I unlock/relock it in the
mptfc_qmnd() function.

Thanks,
 Mike

> 
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> ---
>  drivers/message/fusion/mptfc.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/message/fusion/mptfc.c b/drivers/message/fusion/mptfc.c
> index 3cdd4e9..1189bbe 100644
> --- a/drivers/message/fusion/mptfc.c
> +++ b/drivers/message/fusion/mptfc.c
> @@ -656,9 +656,10 @@ mptfc_qcmd(struct scsi_cmnd *SCpnt, void (*done)(struct scsi_cmnd *))
>  		return 0;
>  	}
>  
> -	err = fc_remote_port_chkready(rport);
> -	if (unlikely(err)) {
> -		SCpnt->result = err;
> +	err = fc_remote_port_queue_ready(rport, SCpnt);
> +	if (err)
> +		return err;
> +	if (SCpnt->result) {
>  		done(SCpnt);
>  		return 0;
>  	}