All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulrich Drepper <drepper@redhat.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: bharata@linux.vnet.ibm.com, libc-alpha@sourceware.org,
	Jan Blunck <jblunck@suse.de>, Erez Zadok <ezk@cs.sunysb.edu>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>, Mingming Cao <cmm@us.ibm.com>,
	Dave Hansen <haveblue@us.ibm.com>
Subject: Re: [RFC] Union mount readdir support in glibc
Date: Fri, 14 Mar 2008 00:13:00 -0700	[thread overview]
Message-ID: <47DA257C.9060409@redhat.com> (raw)
In-Reply-To: <20080314053925.GA10722@ZenIV.linux.org.uk>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Al Viro wrote:
> How about "the first entry returned by getdents(3) after open() is a whiteout
> for e.g. '.'"?  No fstat needed, zero impact for normal directories,
> zero impact for any binaries on old kernels (where you wouldn't have
> unions) and zero impact for old binaries on new kernels unless they
> do getdents() on directory that happens to be a union.

Your definition of "zero impact" doesn't quite match mine.  This would
require significant changes.


> And no lockstep...

Of course there is lockstep.  It is not under the application's control
whether a directory is a union fs or not.  Every implementation except a
pure kernel implementation has this problem.


>> - - How does this work with NFS?
> 
> It won't, kernel-side or done in userland.

Why wouldn't a kernel-side implementation work?


> Actually, do we really need it other than to 0 and to current position
> (i.e. full rewind and a no-op)?

Ever heard of the little function "telldir"?

- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkfaJXwACgkQ2ijCOnn/RHSRpQCZAXNktqSs6WRvxIlTlzUd6GC5
PrAAnRecjUcM6ZHoclzXrFFCsBWuIgid
=8pZl
-----END PGP SIGNATURE-----

  reply	other threads:[~2008-03-14  7:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11  5:55 [RFC] Union mount readdir support in glibc Bharata B Rao
2008-03-11  8:09 ` Roland McGrath
2008-03-11 12:49   ` Bharata B Rao
2008-03-12  4:28   ` Bharata B Rao
2008-03-14  3:53 ` Ulrich Drepper
2008-03-14  5:39   ` Al Viro
2008-03-14  7:13     ` Ulrich Drepper [this message]
2008-03-14  8:41       ` Miklos Szeredi
2008-03-14 17:53         ` Peter Staubach
2008-03-14 20:51           ` Miklos Szeredi
2008-03-14 20:58           ` Trond Myklebust
2008-03-14 15:07   ` Jan Blunck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47DA257C.9060409@redhat.com \
    --to=drepper@redhat.com \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=ezk@cs.sunysb.edu \
    --cc=haveblue@us.ibm.com \
    --cc=hch@lst.de \
    --cc=jblunck@suse.de \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.