From: "Jan Beulich" <jbeulich@novell.com>
To: "Jeremy Fitzhardinge" <jeremy@goop.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: simplify sync_test_bit()
Date: Fri, 14 Mar 2008 15:20:18 +0000 [thread overview]
Message-ID: <47DAA5C2.76E4.0078.0@novell.com> (raw)
In-Reply-To: <47DA93D0.4050708@goop.org>
>#define sync_test_bit(nr, addr) test_bit(nr, addr)
>
>would be better, but seems reasonable to me. Or even an inline for
>consistency.
I'm usually intentionally using just the names, without parameters and
not as inline, in such alias definitions so that in case the name gets used
as a function pointer (arguably unlikely here) there's not going to be
any missing definition or duplicate function instantiation. But from a
functionality point of view, either of the alternatives you suggest is
of course as good.
Jan
next prev parent reply other threads:[~2008-03-14 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 7:56 [PATCH] x86: simplify sync_test_bit() Jan Beulich
2008-03-14 15:03 ` Jeremy Fitzhardinge
2008-03-14 15:20 ` Jan Beulich [this message]
2008-03-14 15:43 ` Jeremy Fitzhardinge
2008-03-21 11:18 ` Ingo Molnar
2008-03-22 20:27 ` Jeremy Fitzhardinge
2008-03-26 7:27 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DAA5C2.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.