[Patch] ccio-dma.c [Was: Yet another ccio fix idea?]

[rubisher <rubisher@scarlet.be>]

Grant Grundler wrote:
> On Wed, Mar 12, 2008 at 10:16:29AM +0100, rubisher wrote:
> ...
>> mmm follwing stuff shouldn't so be enough:
>> Index: b/drivers/parisc/ccio-dma.c
>> ===================================================================
>> --- a/drivers/parisc/ccio-dma.c 2008-03-12 08:49:20.000000000 +0000
>> +++ b/drivers/parisc/ccio-dma.c 2008-03-12 08:50:54.000000000 +0000
>> @@ -624,7 +624,8 @@
>>         ** the real mode coherence index generation of U2, the PDIR entry
>>         ** must be flushed to memory to retain coherence."
>>         */
>> -       asm volatile("fdc %%r0(%0)" : : "r" (pdir_ptr));
>> +       asm volatile("fdc %%r0(%0)" : : "r" (&pdir_ptr[1]));
>> +       asm volatile("fdc %%r0(%0)" : : "r" (&pdir_ptr[0]));
> 
> NACK
> 
>>         asm volatile("sync");
>>  }
>>
>> @@ -695,7 +696,7 @@
>>                 ** Hopefully someone figures out how to patch (NOP) the
>>                 ** FDC/SYNC out at boot time.
>>                 */
>> -               asm volatile("fdc %%r0(%0)" : : "r" (pdir_ptr[7]));
>> +               asm volatile("fdc %%r0(%0)" : : "r" (&pdir_ptr[7]));
> 
> NACK - keep it simple with the original proposed patch.
> 
Ok here it is:
Signed-off-by: Joel Soete <soete dot joel at scarlet dot be>
---
  drivers/parisc/ccio-dma.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/parisc/ccio-dma.c
===================================================================
--- a/drivers/parisc/ccio-dma.c 2008-03-12 08:49:20.000000000 +0000
+++ b/drivers/parisc/ccio-dma.c 2008-03-15 19:19:52.000000000 +0000
@@ -695,7 +695,7 @@
                 ** Hopefully someone figures out how to patch (NOP) the
                 ** FDC/SYNC out at boot time.
                 */
-               asm volatile("fdc %%r0(%0)" : : "r" (pdir_ptr[7]));
+               asm volatile("fdc %%r0(%0)" : : "r" (pdir_ptr));

                 iovp     += IOVP_SIZE;
                 byte_cnt -= IOVP_SIZE;
=== <> ===

[snip]

Hth,
	r.