From: Randy Dunlap <randy.dunlap@oracle.com>
To: schwidefsky@de.ibm.com
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org, Ralph Wuerthner <rwuerthn@de.ibm.com>
Subject: Re: [patch 2/2] zcrypt: add support for large random numbers
Date: Mon, 17 Mar 2008 08:02:28 -0700 [thread overview]
Message-ID: <47DE8804.9010401@oracle.com> (raw)
In-Reply-To: <1205747051.16137.21.camel@localhost>
Martin Schwidefsky wrote:
> On Fri, 2008-03-14 at 09:14 -0700, Randy Dunlap wrote:
>> Linux kernel uses "/**" to indicate the beginning of kernel-doc
>> notation, so when the comment block is not kernel-doc, please don't
>> use that /** to begin the comment block.
>> (multiple occurrences of this)
>
> True. This is done consistently wrong in the zcrypt driver. I would
> prefer to do a separate kernel-doc cleanup patch and leave this patch as
> it is. Ok ?
Sure. Thanks.
--
~Randy
next prev parent reply other threads:[~2008-03-17 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 9:25 [patch 0/2] CEX2C hardware random numbers Martin Schwidefsky
2008-03-14 9:25 ` [patch 1/2] hw_random: allow rng_dev_read() to return hardware errors Martin Schwidefsky
2008-03-31 14:19 ` Herbert Xu
2008-03-14 9:25 ` [patch 2/2] zcrypt: add support for large random numbers Martin Schwidefsky
2008-03-14 16:14 ` Randy Dunlap
2008-03-17 9:44 ` Martin Schwidefsky
2008-03-17 15:02 ` Randy Dunlap [this message]
2008-03-31 14:21 ` Herbert Xu
2008-03-31 14:39 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DE8804.9010401@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=rwuerthn@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.