Re: PATCH - ESI Juli driver

[Pavel Hofman <pavel.hofman@insite.cz>]

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

Takashi Iwai wrote:
> At Mon, 17 Mar 2008 16:50:39 +0100,
> Pavel Hofman wrote:
> 
> Well, then we'll need to find some point to compromise.  Could you
> repost the patch after reducing the callbacks again?
> 
> I'll have also no time from the next week at all -- will be on
> vacation for three weeks.  So, let's kick it out soonish :)
> 
Hi,

Here is the patch. I removed several callbacks and changed _rate_code 
callbacks to _rate ones. You were right, the change did clean the code a 
little bit. The vmaster surprisingly works too :)

The compilation writes
In file included from 
/home/pavel/projects/alsa/alsa-driver/pci/ice1712/juli.c:3:
/home/pavel/projects/alsa/alsa-driver/pci/ice1712/../../alsa-kernel/pci/ice1712/juli.c:139: 
warning: function declaration isn’t a prototype

Routine juli_init_gpio_rates() without any parameter starts on that 
line. I do not know how to fix the warning, could you do so, please?

Thanks a lot.

Pavel.


Signed-off-by: Pavel Hofman <dustin at seznam.cz>

* moving most of clock-specific code to card-specific routines
* support for ESI Juli
* to-be-researched - monitoring of analog/digital inputs

[-- Attachment #2: patch-ice-juli-v2.diff.gz --]
[-- Type: application/x-gzip, Size: 11075 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel