All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] CFI: Small cleanup for FLASH_SHOW_PROGRESS
Date: Wed, 19 Mar 2008 08:25:55 -0400	[thread overview]
Message-ID: <47E10653.1010307@ge.com> (raw)
In-Reply-To: <1205907215-20486-1-git-send-email-sr@denx.de>

Stefan Roese wrote:
> With this patch we don't need that many #ifdef's in the code. It moves
> the subtraction into the macro and defines a NOP-macro when
> CONFIG_FLASH_SHOW_PROGRESS is not defined.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
> 
> Jerry, what do you think? If you are ok with to this one, and
> nobody else has some objections, I'll submit both patches.
> 
>  drivers/mtd/cfi_flash.c |   22 +++++++++-------------
>  1 files changed, 9 insertions(+), 13 deletions(-)

Yes, there was that little birdie in the back of my mind saying this 
could be cleaner when I moved the code into the macro and didn't move 
the increment in too (because the increment was different amounts). 
Thanks for chirping louder.  :-)

Acked-by: Gerald Van Baren <vanbaren@cideas.com>

      reply	other threads:[~2008-03-19 12:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-19  6:13 [U-Boot-Users] [PATCH] CFI: Small cleanup for FLASH_SHOW_PROGRESS Stefan Roese
2008-03-19 12:25 ` Jerry Van Baren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E10653.1010307@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.