Re: [kvm-ppc-devel] guest panic fixed

[Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>]

Hollis Blanchard wrote:
> Thanks to some excellent debugging by Christian, we found the cause of
> our annoying guest panics. We had not implemented exception priorities
> (my bad), so a userspace ITLB miss was being delivered immediately after
> entry to the decrementer interrupt vector. Patch follows,
> http://penguinppc.org/~hollisb/kvm/ updated.
> 
> NFS root with virtio-net still doesn't work for me, but it doesn't
> crash. :)
> 
> @@ -65,12 +68,14 @@ extern void kvmppc_44x_tlb_trace(int act
> 
>  static inline void kvmppc_queue_exception(struct kvm_vcpu *vcpu, int exception)
>  {
> -	set_bit(exception, &vcpu->arch.pending_exceptions);
> +	unsigned int priority = exception_priority[exception];
> +	set_bit(priority, &vcpu->arch.pending_exceptions);

saves a line and a local var on irq path (well the compiler might optimize that anyway)
	set_bit(exception_priority[exception], &vcpu->arch.pending_exceptions);

>  }
> 
>  static inline void kvmppc_clear_exception(struct kvm_vcpu *vcpu, int exception)
>  {
> -	clear_bit(exception, &vcpu->arch.pending_exceptions);
> +	unsigned int priority = exception_priority[exception];
> +	clear_bit(priority, &vcpu->arch.pending_exceptions);

same as above

>  }
> 
>  static inline void kvmppc_set_msr(struct kvm_vcpu *vcpu, u32 new_msr)
 


-- 

Grüsse / regards, 
Christian Ehrhardt
IBM Linux Technology Center, Open Virtualization

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel