From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: ralf@linux-mips.org
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Make KGDB compile on UP
Date: Thu, 20 Mar 2008 23:48:01 +0300 [thread overview]
Message-ID: <47E2CD81.3050107@ru.mvista.com> (raw)
In-Reply-To: <200803202059.37857.sshtylyov@ru.mvista.com>
Hi, I wrote:
> Building UP kernel with KGDB enabled produces the following errors and warning
> (fatal due to -Werror in arch/mips/kernel/Makefile):
>
> In file included from arch/mips/kernel/gdb-stub.c:142:
> include/asm/smp.h:25:1: "raw_smp_processor_id" redefined
> In file included from include/linux/sched.h:69,
> from arch/mips/kernel/gdb-stub.c:126:
> include/linux/smp.h:88:1: this is the location of the previous definition
> In file included from arch/mips/kernel/gdb-stub.c:142:
> include/asm/smp.h:62: error: redefinition of 'smp_send_reschedule'
> include/linux/smp.h:102: error: previous definition of 'smp_send_reschedule' was here
> include/asm/smp.h: In function `smp_send_reschedule':
> include/asm/smp.h:65: error: dereferencing pointer to incomplete type
> arch/mips/kernel/gdb-stub.c: At top level:
> arch/mips/kernel/gdb-stub.c:660: warning: 'kgdb_wait' defined but not used
>
> Fix the errors by not directly including <asm/smp.h> (which is already included
> by <linux/smp.h>) and the warning by enclosing kgdb_wait() in #ifdef CONFIG_SMP.
As usual, forgot to stamp:
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
WBR, Sergei
next prev parent reply other threads:[~2008-03-20 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 17:59 [PATCH] Make KGDB compile on UP Sergei Shtylyov
2008-03-20 20:48 ` Sergei Shtylyov [this message]
2008-04-04 19:35 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E2CD81.3050107@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.