From: "H. Peter Anvin" <hpa@zytor.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: relocate_kernel - use predefined PAGE_SIZE instead of own alias
Date: Fri, 21 Mar 2008 13:50:33 -0700 [thread overview]
Message-ID: <47E41F99.7090904@zytor.com> (raw)
In-Reply-To: <20080321204106.GB9424@cvg>
Cyrill Gorcunov wrote:
> [H. Peter Anvin - Fri, Mar 21, 2008 at 01:18:13PM -0700]
>> Cyrill Gorcunov wrote:
>>> This patch does clean up relocate_kernel_(32|64).S a bit by getting rid
>>> of local PAGE_ALIGNED macro. We should use well-known PAGE_SIZE instead
>>> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
>> Looks good!
>>
>> -hpa
>>
>
> Thanks Peter for review, btw we have in relocate_kernel_32.S
>
> 188: movl %cr4, %eax
> 189: andl $0, %eax
> 190: movl %eax, %cr4
>
> but maybe would be better just replace it with
>
> xorl %eax, %eax
> movl %eax, %cr4
>
> or there is some nonobvious reason not to do so?
>
The only case I can think of would be if the code expects to patch the
zero, but even then it'd be cantankerous, because gas will optimize that
zero down to a single byte.
So, no :)
-hpa
next prev parent reply other threads:[~2008-03-21 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 20:12 [PATCH] x86: relocate_kernel - use predefined PAGE_SIZE instead of own alias Cyrill Gorcunov
2008-03-21 20:18 ` H. Peter Anvin
2008-03-21 20:41 ` Cyrill Gorcunov
2008-03-21 20:50 ` H. Peter Anvin [this message]
2008-03-21 20:52 ` Cyrill Gorcunov
2008-03-21 21:02 ` Cyrill Gorcunov
2008-03-21 20:53 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E41F99.7090904@zytor.com \
--to=hpa@zytor.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.