Re: [patch] hid: only dump report traffic with debug level 2

[Anssi Hannula <anssi.hannula@gmail.com>]

Jiri Kosina wrote:
> On Fri, 21 Mar 2008, Anssi Hannula wrote:
> 
>> Currently using debug=1 with hid module prints out all sent and received 
>> reports to the kernel log, while in many cases we only want to see the 
>> report descriptors and hid-input mappings that are printed when a device 
>> is probed.
> 
> Hi Anssi,
> 
> thanks for your patch, I agree that making this more configurable makes 
> sense.
> 
> But I would propose staying backwards compatible, i.e. debug=1 does the 
> whole dump, debug=2 excludes the individual reports but still dumps the 
> report descriptor and mappings etc. What do you think?

Well, I think having higher debug level should mean more debugging
output and that this logic is more important than backwards
compatibility of a debug option, it is not like it is going to break any
software or so.

But I don't care too much about it, feel free to do it the other way as
well :)

-- 
Anssi Hannula