From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [MIPS] Implement flush_cache()
Date: Mon, 24 Mar 2008 01:25:08 +0900 [thread overview]
Message-ID: <47E68464.7010409@ruby.dti.ne.jp> (raw)
In-Reply-To: <47E0087D.1030009@ruby.dti.ne.jp>
Shinya Kuribayashi wrote:
> Andrew Dyer wrote:
>> looking at how cache_flush() is used (see common/cmd_load.c,
>> common/cmd_elf.c, etc), I believe this loop should also do a cache_op
>> with Hit_Invalidate_I to invalidate the icache.
>>
>> seems like it would be easier to read if the condition was included in
>> the while() statement
>
> Hm, then is this ok?
<snip>
> @@ -41,6 +52,17 @@ int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>
> void flush_cache(ulong start_addr, ulong size)
> {
> + unsigned long lsize = CFG_DCACHE_SIZE;
^^^^^^^^^^^^^^^
Oops, this should have been cache line size.
Patch updated.
P.S. I'll introduce <asm/r4kcache.h> and remove cache_op macro in the
future. But it takes some time.
================>
[MIPS] Implement flush_cache()
Signed-off-by: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
---
cpu/mips/cpu.c | 22 ++++++++++++++++++++++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/cpu/mips/cpu.c b/cpu/mips/cpu.c
index 7559ac6..de70c4d 100644
--- a/cpu/mips/cpu.c
+++ b/cpu/mips/cpu.c
@@ -25,6 +25,17 @@
#include <command.h>
#include <asm/inca-ip.h>
#include <asm/mipsregs.h>
+#include <asm/cacheops.h>
+
+#define cache_op(op,addr) \
+ __asm__ __volatile__( \
+ " .set push \n" \
+ " .set noreorder \n" \
+ " .set mips3\n\t \n" \
+ " cache %0, %1 \n" \
+ " .set pop \n" \
+ : \
+ : "i" (op), "R" (*(unsigned char *)(addr)))
int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
{
@@ -41,6 +52,17 @@ int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
void flush_cache(ulong start_addr, ulong size)
{
+ unsigned long lsize = CFG_CACHELINE_SIZE;
+ unsigned long addr = start_addr & ~(lsize - 1);
+ unsigned long aend = (start_addr + size - 1) & ~(lsize - 1);
+
+ while (1) {
+ cache_op(Hit_Writeback_Inv_D, start_addr);
+ cache_op(Hit_Invalidate_I, start_addr);
+ if (addr == aend)
+ break;
+ addr += lsize;
+ }
}
void write_one_tlb(int index, u32 pagemask, u32 hi, u32 low0, u32 low1)
prev parent reply other threads:[~2008-03-23 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 16:42 [U-Boot-Users] [MIPS] Implement flush_cache() Shinya Kuribayashi
2008-03-18 17:13 ` Andrew Dyer
2008-03-18 18:22 ` Shinya Kuribayashi
2008-03-23 16:25 ` Shinya Kuribayashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E68464.7010409@ruby.dti.ne.jp \
--to=skuribay@ruby.dti.ne.jp \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.