-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Edward Shishkin wrote: > Jeff Mahoney wrote: > >> Edward Shishkin wrote: >> >> >Thanks, queued. >> >Btw I got compilation errors. Have you missed something? >> >> >> Yeah, I guess I did. It builds fine on my SLES boxes, but not on my >> openSUSE machines. I'll them up for that (I need to anyway) and resend. >> > > The following makes me think that something is > missed (the patch series was applied to 3.6.19): > > main.c: In function `reiserfs_check_auto_state': > main.c:971: warning: unsigned int format, long int arg (arg 3) > mkreiserfs.c: In function `main': > mkreiserfs.c:730: warning: implicit declaration of function `block_size_ok' This was a missing entry in reiserfs_lib.h. I've attached an updated patch that adds it. I've also attached an updated reiserfsprogs-better-fsck-a-behavior. The only difference is the addition of "#define _XOPEN_SOURCE" for the strptime prototype. There was a warning for that too. > tune.o(.text+0xa86): In function `main': > /home/edward/work/reiserfsprogs-3.6.19/tune/tune.c:268: undefined > reference to `parse_time' > collect2: ld returned 1 exit status > make[1]: *** [reiserfstune] Error 1 This one looks like you didn't run autoreconf before running ./configure. Since I've added files and changed Makefile.am, it needs to regenerate the Makefile.in's. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.8 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkfnES4ACgkQLPWxlyuTD7KtQQCgmjsZlThZ9I+RqGYjrrHS2ssA 0KcAmwc4Lah1F8RsOtPvPD0St04Pya1Q =MjSs -----END PGP SIGNATURE-----