From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc clock + general support Date: Mon, 24 Mar 2008 09:11:40 +0200 Message-ID: <47E7542C.60901@qumranet.com> References: <1206282453.18800.31.camel@localhost.localdomain> <200803231619.32472.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , qemu-devel@nongnu.org To: Paul Brook Return-path: In-Reply-To: <200803231619.32472.paul@codesourcery.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Paul Brook wrote: > On Sunday 23 March 2008, Dor Laor wrote: > >> --- a/qemu/hw/irq.c >> +++ b/qemu/hw/irq.c >> @@ -30,6 +30,8 @@ struct IRQState { >> int n; >> }; >> >> +uint32_t qemu_irq_acked[NR_IRQ_WORDS]; >> > > This is absolute rubbish. The whole point of the IRQ framework is that it > doesn't assume a single flat IRQ controller. > > x86 does have a single irq space (even when using cascaded pics or multiple ioapics), called gsi (for generalized system interrupt, or something). It is possible to enumerate all irqs on all platforms that have a finite number of them. It may be better though to identify an irq by a (controller_id, irq_line) pair instead. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JditW-0005gv-1E for qemu-devel@nongnu.org; Mon, 24 Mar 2008 05:23:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JditP-0005fb-Ru for qemu-devel@nongnu.org; Mon, 24 Mar 2008 05:23:02 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JditN-0005f6-W7 for qemu-devel@nongnu.org; Mon, 24 Mar 2008 05:22:58 -0400 Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JditN-0002PV-TH for qemu-devel@nongnu.org; Mon, 24 Mar 2008 05:22:57 -0400 Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194] helo=il.qumranet.com) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jdhk4-0001Qe-Cv for qemu-devel@nongnu.org; Mon, 24 Mar 2008 04:09:16 -0400 Message-ID: <47E7542C.60901@qumranet.com> Date: Mon, 24 Mar 2008 09:11:40 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [kvm-devel] [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc clock + general support References: <1206282453.18800.31.camel@localhost.localdomain> <200803231619.32472.paul@codesourcery.com> In-Reply-To: <200803231619.32472.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: kvm-devel , qemu-devel@nongnu.org Paul Brook wrote: > On Sunday 23 March 2008, Dor Laor wrote: > >> --- a/qemu/hw/irq.c >> +++ b/qemu/hw/irq.c >> @@ -30,6 +30,8 @@ struct IRQState { >> int n; >> }; >> >> +uint32_t qemu_irq_acked[NR_IRQ_WORDS]; >> > > This is absolute rubbish. The whole point of the IRQ framework is that it > doesn't assume a single flat IRQ controller. > > x86 does have a single irq space (even when using cascaded pics or multiple ioapics), called gsi (for generalized system interrupt, or something). It is possible to enumerate all irqs on all platforms that have a finite number of them. It may be better though to identify an irq by a (controller_id, irq_line) pair instead. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.