All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <junio@pobox.com>,
	Michele Ballabio <barra_cuda@katamail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 2/5] test_must_fail: 129 is a valid error code from   usage()
Date: Tue, 25 Mar 2008 12:21:50 +0100	[thread overview]
Message-ID: <47E8E04E.6060606@viscovery.net> (raw)
In-Reply-To: <alpine.LSU.1.00.0803251100520.10660@wbgn129.biozentrum.uni-wuerzburg.de>

Johannes Schindelin schrieb:
> Hi,
> 
> On Mon, 24 Mar 2008, Junio C Hamano wrote:
> 
>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>> index 870b255..7c2a8ba 100644
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -300,7 +300,7 @@ test_expect_code () {
>>  
>>  test_must_fail () {
>>  	"$@"
>> -	test $? -gt 0 -a $? -le 128
>> +	test $? -gt 0 -a $? -le 129
> 
> IIRC exit status is a signed byte on Win32.  Can somebody check?

Not at the shell level. This command:

   git branch foo bar baz

exits with 129 both when invoked by bash ($?) and CMD (%ERRORLEVEL%).

-- Hannes

  reply	other threads:[~2008-03-25 11:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-23 20:50 [PATCH 2/2] builtin-prune.c: fix object parsing and use parse_options() Michele Ballabio
2008-03-23 22:21 ` Johannes Schindelin
2008-03-24 12:31   ` Michele Ballabio
2008-03-24 13:13     ` Johannes Schindelin
2008-03-24 14:02       ` [PATCH 3/2] parse-options.c: introduce OPT_DATE Michele Ballabio
2008-03-24 13:59         ` Johannes Schindelin
2008-03-24 16:25         ` Michele Ballabio
2008-03-24 20:03           ` Johannes Schindelin
2008-03-24 20:10         ` Junio C Hamano
2008-03-24 21:18           ` Michele Ballabio
2008-03-25  6:58             ` Junio C Hamano
2008-03-25  6:59             ` [PATCH 1/5] " Junio C Hamano
2008-03-25  6:59             ` [PATCH 2/5] test_must_fail: 129 is a valid error code from usage() Junio C Hamano
2008-03-25 10:01               ` Johannes Schindelin
2008-03-25 11:21                 ` Johannes Sixt [this message]
2008-03-25 19:27                   ` Johannes Schindelin
2008-03-25  6:59             ` [PATCH 3/5] Add tests for git-prune Junio C Hamano
2008-03-25  6:59             ` [PATCH 4/5] builtin-prune.c: use parse_options() Junio C Hamano
2008-03-25  6:59             ` [PATCH 5/5] builtin-prune: protect objects listed on the command line Junio C Hamano
2008-03-27 16:32               ` Junio C Hamano
2008-03-27 16:35                 ` Johannes Schindelin
2008-03-27 21:11                   ` Michele Ballabio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E8E04E.6060606@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=barra_cuda@katamail.com \
    --cc=git@vger.kernel.org \
    --cc=junio@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.