diff for duplicates of <47E91589.50906@goop.org> diff --git a/a/1.txt b/N1/1.txt index ceeff34..d4916c4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -178,7 +178,7 @@ Looks reasonable. One comment below. > -{ > - int irq = evtchn_to_irq[chn]; > - -> - BUG_ON(irq = -1); +> - BUG_ON(irq == -1); > -#ifdef CONFIG_SMP > - irq_desc[irq].affinity = cpumask_of_cpu(cpu); > -#endif @@ -282,10 +282,10 @@ Looks reasonable. One comment below. > - > - /* Only allocate from dynirq range */ > - for (irq = 0; irq < NR_IRQS; irq++) -> - if (irq_bindcount[irq] = 0) +> - if (irq_bindcount[irq] == 0) > - break; > - -> - if (irq = NR_IRQS) +> - if (irq == NR_IRQS) > - panic("No available IRQ to bind to: increase > NR_IRQS!\n"); > - @@ -300,7 +300,7 @@ Looks reasonable. One comment below. > - > - irq = evtchn_to_irq[evtchn]; > - -> - if (irq = -1) { +> - if (irq == -1) { > - irq = find_unbound_irq(); > - > - dynamic_irq_init(irq); @@ -328,7 +328,7 @@ Looks reasonable. One comment below. > - spin_lock(&irq_mapping_update_lock); > - > - irq = per_cpu(ipi_to_irq, cpu)[ipi]; -> - if (irq = -1) { +> - if (irq == -1) { > - irq = find_unbound_irq(); > - if (irq < 0) > - goto out; @@ -368,7 +368,7 @@ Looks reasonable. One comment below. > - > - irq = per_cpu(virq_to_irq, cpu)[virq]; > - -> - if (irq = -1) { +> - if (irq == -1) { > - bind_virq.virq = virq; > - bind_virq.vcpu = cpu; > - if (HYPERVISOR_event_channel_op(EVTCHNOP_bind_virq, @@ -404,7 +404,7 @@ Looks reasonable. One comment below. > - > - spin_lock(&irq_mapping_update_lock); > - -> - if (VALID_EVTCHN(evtchn) && (--irq_bindcount[irq] = 0)) { +> - if (VALID_EVTCHN(evtchn) && (--irq_bindcount[irq] == 0)) { > - close.port = evtchn; > - if (HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) > != 0) @@ -824,7 +824,7 @@ Looks reasonable. One comment below. > +{ > + int irq = evtchn_to_irq[chn]; > + -> + BUG_ON(irq = -1); +> + BUG_ON(irq == -1); > +#ifdef CONFIG_SMP > + irq_desc[irq].affinity = cpumask_of_cpu(cpu); > +#endif @@ -928,10 +928,10 @@ Looks reasonable. One comment below. > + > + /* Only allocate from dynirq range */ > + for (irq = 0; irq < NR_IRQS; irq++) -> + if (irq_bindcount[irq] = 0) +> + if (irq_bindcount[irq] == 0) > + break; > + -> + if (irq = NR_IRQS) +> + if (irq == NR_IRQS) > + panic("No available IRQ to bind to: increase > NR_IRQS!\n"); > + @@ -946,7 +946,7 @@ Looks reasonable. One comment below. > + > + irq = evtchn_to_irq[evtchn]; > + -> + if (irq = -1) { +> + if (irq == -1) { > + irq = find_unbound_irq(); > + > + dynamic_irq_init(irq); @@ -974,7 +974,7 @@ Looks reasonable. One comment below. > + spin_lock(&irq_mapping_update_lock); > + > + irq = per_cpu(ipi_to_irq, cpu)[ipi]; -> + if (irq = -1) { +> + if (irq == -1) { > + irq = find_unbound_irq(); > + if (irq < 0) > + goto out; @@ -1014,7 +1014,7 @@ Looks reasonable. One comment below. > + > + irq = per_cpu(virq_to_irq, cpu)[virq]; > + -> + if (irq = -1) { +> + if (irq == -1) { > + bind_virq.virq = virq; > + bind_virq.vcpu = cpu; > + if (HYPERVISOR_event_channel_op(EVTCHNOP_bind_virq, @@ -1050,7 +1050,7 @@ Looks reasonable. One comment below. > + > + spin_lock(&irq_mapping_update_lock); > + -> + if (VALID_EVTCHN(evtchn) && (--irq_bindcount[irq] = 0)) { +> + if (VALID_EVTCHN(evtchn) && (--irq_bindcount[irq] == 0)) { > + close.port = evtchn; > + if (HYPERVISOR_event_channel_op(EVTCHNOP_close, &close) > != 0) diff --git a/a/content_digest b/N1/content_digest index aa42eb6..57dc127 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,7 +5,7 @@ "ref\010EA09EFD8728347A513008B6B0DA77A02F37916@pdsmsx411.ccr.corp.intel.com\0" "From\0Jeremy Fitzhardinge <jeremy@goop.org>\0" "Subject\0Re: Xen common code across architecture\0" - "Date\0Tue, 25 Mar 2008 15:08:57 +0000\0" + "Date\0Tue, 25 Mar 2008 08:08:57 -0700\0" "To\0Dong" " Eddie <eddie.dong@intel.com>\0" "Cc\0virtualization@lists.linux-foundation.org" @@ -196,7 +196,7 @@ "> -{\n" "> -\tint irq = evtchn_to_irq[chn];\n" "> -\n" - "> -\tBUG_ON(irq = -1);\n" + "> -\tBUG_ON(irq == -1);\n" "> -#ifdef CONFIG_SMP\n" "> -\tirq_desc[irq].affinity = cpumask_of_cpu(cpu);\n" "> -#endif\n" @@ -300,10 +300,10 @@ "> -\n" "> -\t/* Only allocate from dynirq range */\n" "> -\tfor (irq = 0; irq < NR_IRQS; irq++)\n" - "> -\t\tif (irq_bindcount[irq] = 0)\n" + "> -\t\tif (irq_bindcount[irq] == 0)\n" "> -\t\t\tbreak;\n" "> -\n" - "> -\tif (irq = NR_IRQS)\n" + "> -\tif (irq == NR_IRQS)\n" "> -\t\tpanic(\"No available IRQ to bind to: increase\n" "> NR_IRQS!\\n\");\n" "> -\n" @@ -318,7 +318,7 @@ "> -\n" "> -\tirq = evtchn_to_irq[evtchn];\n" "> -\n" - "> -\tif (irq = -1) {\n" + "> -\tif (irq == -1) {\n" "> -\t\tirq = find_unbound_irq();\n" "> -\n" "> -\t\tdynamic_irq_init(irq);\n" @@ -346,7 +346,7 @@ "> -\tspin_lock(&irq_mapping_update_lock);\n" "> -\n" "> -\tirq = per_cpu(ipi_to_irq, cpu)[ipi];\n" - "> -\tif (irq = -1) {\n" + "> -\tif (irq == -1) {\n" "> -\t\tirq = find_unbound_irq();\n" "> -\t\tif (irq < 0)\n" "> -\t\t\tgoto out;\n" @@ -386,7 +386,7 @@ "> -\n" "> -\tirq = per_cpu(virq_to_irq, cpu)[virq];\n" "> -\n" - "> -\tif (irq = -1) {\n" + "> -\tif (irq == -1) {\n" "> -\t\tbind_virq.virq = virq;\n" "> -\t\tbind_virq.vcpu = cpu;\n" "> -\t\tif (HYPERVISOR_event_channel_op(EVTCHNOP_bind_virq,\n" @@ -422,7 +422,7 @@ "> -\n" "> -\tspin_lock(&irq_mapping_update_lock);\n" "> -\n" - "> -\tif (VALID_EVTCHN(evtchn) && (--irq_bindcount[irq] = 0)) {\n" + "> -\tif (VALID_EVTCHN(evtchn) && (--irq_bindcount[irq] == 0)) {\n" "> -\t\tclose.port = evtchn;\n" "> -\t\tif (HYPERVISOR_event_channel_op(EVTCHNOP_close, &close)\n" "> != 0)\n" @@ -842,7 +842,7 @@ "> +{\n" "> +\tint irq = evtchn_to_irq[chn];\n" "> +\n" - "> +\tBUG_ON(irq = -1);\n" + "> +\tBUG_ON(irq == -1);\n" "> +#ifdef CONFIG_SMP\n" "> +\tirq_desc[irq].affinity = cpumask_of_cpu(cpu);\n" "> +#endif\n" @@ -946,10 +946,10 @@ "> +\n" "> +\t/* Only allocate from dynirq range */\n" "> +\tfor (irq = 0; irq < NR_IRQS; irq++)\n" - "> +\t\tif (irq_bindcount[irq] = 0)\n" + "> +\t\tif (irq_bindcount[irq] == 0)\n" "> +\t\t\tbreak;\n" "> +\n" - "> +\tif (irq = NR_IRQS)\n" + "> +\tif (irq == NR_IRQS)\n" "> +\t\tpanic(\"No available IRQ to bind to: increase\n" "> NR_IRQS!\\n\");\n" "> +\n" @@ -964,7 +964,7 @@ "> +\n" "> +\tirq = evtchn_to_irq[evtchn];\n" "> +\n" - "> +\tif (irq = -1) {\n" + "> +\tif (irq == -1) {\n" "> +\t\tirq = find_unbound_irq();\n" "> +\n" "> +\t\tdynamic_irq_init(irq);\n" @@ -992,7 +992,7 @@ "> +\tspin_lock(&irq_mapping_update_lock);\n" "> +\n" "> +\tirq = per_cpu(ipi_to_irq, cpu)[ipi];\n" - "> +\tif (irq = -1) {\n" + "> +\tif (irq == -1) {\n" "> +\t\tirq = find_unbound_irq();\n" "> +\t\tif (irq < 0)\n" "> +\t\t\tgoto out;\n" @@ -1032,7 +1032,7 @@ "> +\n" "> +\tirq = per_cpu(virq_to_irq, cpu)[virq];\n" "> +\n" - "> +\tif (irq = -1) {\n" + "> +\tif (irq == -1) {\n" "> +\t\tbind_virq.virq = virq;\n" "> +\t\tbind_virq.vcpu = cpu;\n" "> +\t\tif (HYPERVISOR_event_channel_op(EVTCHNOP_bind_virq,\n" @@ -1068,7 +1068,7 @@ "> +\n" "> +\tspin_lock(&irq_mapping_update_lock);\n" "> +\n" - "> +\tif (VALID_EVTCHN(evtchn) && (--irq_bindcount[irq] = 0)) {\n" + "> +\tif (VALID_EVTCHN(evtchn) && (--irq_bindcount[irq] == 0)) {\n" "> +\t\tclose.port = evtchn;\n" "> +\t\tif (HYPERVISOR_event_channel_op(EVTCHNOP_close, &close)\n" "> != 0)\n" @@ -1332,4 +1332,4 @@ "\n" J -770ddb17e999a9efa8c1f3e912a39a1da1429563cec6b24d9e1a1865f08d6f25 +9319a85a4a7824b051cbcb99fde0a18306420c552aa9d3e5654c7fdbc2a083a7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.