From: Glauber Costa <gcosta@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
glommer@gmail.com, tglx@linutronix.de, yhlu.kernel@gmail.com
Subject: Re: [PATCH 2/2] [PATCH] move apic declarations to mach_apic.h
Date: Tue, 25 Mar 2008 18:10:01 -0300 [thread overview]
Message-ID: <47E96A29.4000503@redhat.com> (raw)
In-Reply-To: <20080325195818.GA12302@elte.hu>
Ingo Molnar wrote:
> * Glauber Costa <gcosta@redhat.com> wrote:
>
>> take them out of the x86_64-specific asm/mach_apic.h
>
> this broke the 32-bit build:
>
> In file included from arch/x86/kernel/cpu/amd.c:8:
> include/asm-x86/mach-default/mach_apic.h: In function 'init_apic_ldr':
> include/asm-x86/mach-default/mach_apic.h:47: error: implicit declaration of function 'apic_write_around'
> [...]
>
> .config attached.
>
> Ingo
>
Problem is that local apic is not always present.
I'm sending a replacement.
next prev parent reply other threads:[~2008-03-25 21:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 19:52 [PATCH 1/2] move ipi definitions to mach_ipi.h Glauber Costa
2008-03-24 19:52 ` [PATCH 2/2] move apic declarations to mach_apic.h Glauber Costa
2008-03-24 22:44 ` Yinghai Lu
2008-03-25 14:37 ` Ingo Molnar
2008-03-25 14:37 ` [PATCH 1/2] move ipi definitions to mach_ipi.h Ingo Molnar
2008-03-25 15:06 ` Ingo Molnar
2008-03-25 16:28 ` [PATCH 0/2] get rid of mach_apic.h Glauber Costa
2008-03-25 16:28 ` [PATCH 1/2] [PATCH] move ipi definitions to mach_ipi.h Glauber Costa
2008-03-25 16:28 ` [PATCH 2/2] [PATCH] move apic declarations to mach_apic.h Glauber Costa
2008-03-25 19:58 ` Ingo Molnar
2008-03-25 21:10 ` Glauber Costa [this message]
2008-03-26 4:47 ` Ingo Molnar
2008-03-26 4:49 ` Ingo Molnar
2008-03-26 11:49 ` Glauber Costa
2008-03-25 16:33 ` [PATCH 0/2] get rid of mach_apic.h Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2008-03-25 21:10 [PATCH 2/2] [PATCH] move apic declarations to mach_apic.h Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E96A29.4000503@redhat.com \
--to=gcosta@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=glommer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.