All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Florian Fainelli <florian.fainelli@telecomint.eu>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH] Add support the Korina (IDT RC32434) Ethernet MAC
Date: Wed, 26 Mar 2008 00:36:19 -0400	[thread overview]
Message-ID: <47E9D2C3.7050006@garzik.org> (raw)
In-Reply-To: <200803191714.52407.florian.fainelli@telecomint.eu>

Florian Fainelli wrote:
> Hi Francois,
> 
> Le lundi 17 mars 2008, Francois Romieu a écrit :
>>> Thanks for your comments, here is a third try which adresses the
>>> mentionned problems.
> 
> It is allright, thanks for your concise answers. 1-2,4-15 should be fixed now.
> 
>> 3. korina_rx() still drops the received skb each time dev_alloc_skb fails.
>>    This is far from optimal.
> 
> I now simply break into the while loop, which should allow more luck for failed allocation descriptors on next round. Seems like other 
> 
> Also, I fixed the multicast handling which was not done for filtered multicast traffic.
> 
> Below is the fourth try of the driver.
> --
> From: Florian Fainelli <florian.fainelli@telecomint.eu>
> Subject: [PATCH] Add support the Korina (IDT RC32434) Ethernet MAC
> 
> This patch adds support for the IDT rc32434 Ethernet MAC
> we can find in the IDT boards and the Mikrotik RB500.
> Driver references some code from the linux-mips RB500
> support.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@telecomint.eu>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> Signed-off-by: Philip Rischel <rischelp@idt.com>

I applied this version...  please send changes after this as separate 
patches



      parent reply	other threads:[~2008-03-26  4:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05 22:45 [PATCH] Add support the Korina (IDT RC32434) Ethernet MAC Florian Fainelli
2008-03-05 23:35 ` Johannes Berg
2008-03-07 10:07   ` Florian Fainelli
2008-03-07 10:45 ` Johannes Berg
2008-03-08 18:05   ` Florian Fainelli
2008-03-10 20:55     ` Florian Fainelli
2008-03-10 22:30     ` Francois Romieu
2008-03-13 10:55       ` Florian Fainelli
2008-03-17 22:31         ` Francois Romieu
2008-03-19 16:14           ` Florian Fainelli
2008-03-19 20:26             ` Francois Romieu
2008-03-19 21:17               ` Florian Fainelli
2008-03-19 21:55                 ` Francois Romieu
2008-03-25 20:55                   ` Florian Fainelli
2008-03-25 22:45                     ` Francois Romieu
2008-03-26  4:36             ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E9D2C3.7050006@garzik.org \
    --to=jeff@garzik.org \
    --cc=davem@davemloft.net \
    --cc=florian.fainelli@telecomint.eu \
    --cc=johannes@sipsolutions.net \
    --cc=nbd@openwrt.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.