Re: [PATCH] [NET] phy/broadcom: add support for BCM5481 PHY

[Jeff Garzik <jgarzik@pobox.com>]

Anton Vorontsov wrote:
> On Wed, Feb 06, 2008 at 06:44:32AM -0500, Jeff Garzik wrote:
>> Anton Vorontsov wrote:
>>> This patch adds support for BCM5481 PHY. Unfortunately it's hard to
>>> get specifications for this PHY, so its special register 0x18 isn't
>>> annotated properly (but we know it's used to set up the delays).
>>>
>>> I've kept the magic numbers, so we'll not forget to fix it at the
>>> first opportunity, and will name that register and its bits correctly.
>>>
>>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> [...]
>>> +static struct phy_driver bcm5481_driver = {
>>> +	.phy_id		= 0x0143bca0,
>>> +	.phy_id_mask	= 0xfffffff0,
> [...]
>> applied
> 
> :-) You applied "PHYLIB: Add BCM5482 PHY support", but my
> patch is for another PHY -- BCM5481. Here is another try,
> rebased on top of previous commit:
> 
> - - - -
> From: Anton Vorontsov <avorontsov@ru.mvista.com>
> Subject: phylib, broadcom: add support for BCM5481 PHY
> 
> This patch adds support for BCM5481 PHY. Unfortunately it's hard to
> get specifications for this PHY, so its special register 0x18 isn't
> annotated properly (but we know it's used to set up the delays).
> 
> I've kept the magic numbers, so we'll not forget to fix it at the
> first opportunity, and will name that register and its bits correctly.
> 
> p.s. also fixed the line with broken indention, introduced by
> commit 03157ac31eb4a8883382a212b161d2e6c5059fbf
>     PHYLIB: Add BCM5482 PHY support
> 
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
>  drivers/net/phy/broadcom.c |   57 +++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 56 insertions(+), 1 deletions(-)

applied