From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JeOtd-0002Yp-Gq for user-mode-linux-devel@lists.sourceforge.net; Tue, 25 Mar 2008 23:14:01 -0700 Received: from viefep18-int.chello.at ([213.46.255.22] helo=viefep19-int.chello.at) by mail.sourceforge.net with esmtp (Exim 4.44) id 1JeOtc-00078Y-Ie for user-mode-linux-devel@lists.sourceforge.net; Tue, 25 Mar 2008 23:14:01 -0700 Message-ID: <47E9E99F.5080003@trash.net> Date: Wed, 26 Mar 2008 07:13:51 +0100 From: Patrick McHardy MIME-Version: 1.0 References: <47E9E331.1010105@trash.net> <47E9E8CD.1060408@garzik.org> In-Reply-To: <47E9E8CD.1060408@garzik.org> Subject: Re: [uml-devel] [UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Jeff Garzik Cc: Linux Netdev List , jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net Jeff Garzik wrote: >> static void uml_net_set_multicast_list(struct net_device *dev) >> { >> - if (dev->flags & IFF_PROMISC) >> - return; >> - else if (dev->mc_count) >> - dev->flags |= IFF_ALLMULTI; >> - else dev->flags &= ~IFF_ALLMULTI; >> + return; >> } > > > > Might as well just delete the hook at that point... I kept it so SIOCADDMULTI/SIOCDELMULTI ioctls continue to work on UML devices. I don't know if any userspace applications check for errors when using these ioctls, this way nothing can break. ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list Date: Wed, 26 Mar 2008 07:13:51 +0100 Message-ID: <47E9E99F.5080003@trash.net> References: <47E9E331.1010105@trash.net> <47E9E8CD.1060408@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net, Linux Netdev List To: Jeff Garzik Return-path: Received: from viefep18-int.chello.at ([213.46.255.22]:57850 "EHLO viefep19-int.chello.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751938AbYCZGNz (ORCPT ); Wed, 26 Mar 2008 02:13:55 -0400 In-Reply-To: <47E9E8CD.1060408@garzik.org> Sender: netdev-owner@vger.kernel.org List-ID: Jeff Garzik wrote: >> static void uml_net_set_multicast_list(struct net_device *dev) >> { >> - if (dev->flags & IFF_PROMISC) >> - return; >> - else if (dev->mc_count) >> - dev->flags |= IFF_ALLMULTI; >> - else dev->flags &= ~IFF_ALLMULTI; >> + return; >> } > > > > Might as well just delete the hook at that point... I kept it so SIOCADDMULTI/SIOCDELMULTI ioctls continue to work on UML devices. I don't know if any userspace applications check for errors when using these ioctls, this way nothing can break.