From: Kevin Wolf <kwolf@suse.de>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Otavio Salvador <otavio@ossystems.com.br>
Subject: Re: The two image formats called qcow
Date: Wed, 26 Mar 2008 09:50:06 +0100 [thread overview]
Message-ID: <47EA0E3E.4030200@suse.de> (raw)
In-Reply-To: <C40FB571.15662%keir.fraser@eu.citrix.com>
Keir Fraser schrieb:
> It's tricky where users' non-volatile storage is concerned though. Other
> than that I would say the bug should be fixed immediately. Is there an easy
> way to detect with reasonable reliability whether we have an old or new
> image? Failing that we may have to provide a tool to convert old images to
> new format.
Something like "that number looks too big, it be must little endian"
could easily turn into "that harddisk looks big, let's break the image",
I suspect.
However, I just noticed that the tapdisk qcow driver writes an extended
Xen-specific header to the image file. This should be reliable enough to
detect tapdisk images.
Is it an option to convert broken images to big endian when it is opened
for the first time in ioemu? In this case, the fix for older versions
could be in one place at least instead of being scattered over the whole
file. Then you wouldn't be able to open such a file with tapdisk again,
though.
Kevin
next prev parent reply other threads:[~2008-03-26 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 17:25 The two image formats called qcow Kevin Wolf
2008-03-25 18:58 ` Otavio Salvador
2008-03-26 8:10 ` Keir Fraser
2008-03-26 8:50 ` Kevin Wolf [this message]
2008-03-26 13:03 ` Otavio Salvador
2008-03-26 13:54 ` Kevin Wolf
2008-03-26 14:02 ` Keir Fraser
2008-03-26 14:07 ` Kevin Wolf
2008-03-26 14:15 ` Keir Fraser
2008-03-26 14:22 ` Kevin Wolf
2008-03-27 9:55 ` [PATCH] tapdisk: Fix L1 table endianess of qcow images Kevin Wolf
2008-03-26 13:23 ` The two image formats called qcow Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EA0E3E.4030200@suse.de \
--to=kwolf@suse.de \
--cc=keir.fraser@eu.citrix.com \
--cc=otavio@ossystems.com.br \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.