All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <aystarik@gmail.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Len Brown <lenb@kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Corentin CHARY <corentincj@iksaif.net>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@lists.linux-foundation.org
Subject: Re: ISA -> ISA_ (Re: [GIT PATCH] ACPI patches for 2.6.25-rc6)
Date: Wed, 26 Mar 2008 20:24:41 +0300	[thread overview]
Message-ID: <47EA86D9.7040404@gmail.com> (raw)
In-Reply-To: <200803260956.55804.bjorn.helgaas@hp.com>

Bjorn Helgaas wrote:
> I'm curious about how this works.  I disassembled the DSDT from
> http://bugzilla.kernel.org/show_bug.cgi?id=4773 (I attached the disassembly
> at http://bugzilla.kernel.org/attachment.cgi?id=15448&action=view), and
> the _PRT contains "_SB" and "ISA" (no trailing underscores):
>
>                 Package (0x04)
>                 {
>                     0x000DFFFF, 
>                     0x00, 
>                     \_SB.PCI0.ISA.LNKA, 
>                     0x00
>                 }
>
> But by the time we get to acpi_pci_irq_add_entry(), we've added the
> underscores somewhere (see
> http://bugzilla.kernel.org/attachment.cgi?id=15423&action=view):
>
>   0000:00:0d[A] -> \_SB_.PCI0.ISA_.LNKA
>
> I don't know where this happens, but it certainly confused me, and
> it seems like it could lead to other bugs.
>   
ACPI is supposed to add trailing underscore for pad all names to 4 bytes.
So ISA will be padded to ISA_.

Regards,
Alex.

  parent reply	other threads:[~2008-03-26 17:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18  9:10 [GIT PATCH] ACPI patches for 2.6.25-rc6 Len Brown
2008-03-26  8:16 ` Ingo Molnar
2008-03-26 15:32   ` ISA -> ISA_ (Re: [GIT PATCH] ACPI patches for 2.6.25-rc6) Len Brown
2008-03-26 15:32   ` Len Brown
2008-03-26 15:45     ` Corentin CHARY
2008-03-26 15:45     ` Corentin CHARY
2008-03-26 15:45       ` Corentin CHARY
2008-03-26 16:33       ` Henrique de Moraes Holschuh
2008-03-26 16:33         ` Henrique de Moraes Holschuh
2008-03-26 15:56     ` Bjorn Helgaas
2008-03-26 15:56     ` Bjorn Helgaas
2008-03-26 17:24       ` Alexey Starikovskiy
2008-03-26 17:24       ` Alexey Starikovskiy [this message]
2008-03-26 18:47         ` Bjorn Helgaas
2008-03-26 18:47         ` Bjorn Helgaas
2008-03-26 19:21           ` Alexey Starikovskiy
2008-03-26 19:21           ` Alexey Starikovskiy
2008-03-26  8:16 ` [GIT PATCH] ACPI patches for 2.6.25-rc6 Ingo Molnar
     [not found] <200803261400.22662.lenb@kernel.org>
     [not found] ` <B28E9812BAF6E2498B7EC5C427F293A4048009DF@orsmsx415.amr.corp.intel.com>
2008-03-27  5:28   ` ISA -> ISA_ (Re: [GIT PATCH] ACPI patches for 2.6.25-rc6) Len Brown
2008-03-27 16:28     ` Moore, Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47EA86D9.7040404@gmail.com \
    --to=aystarik@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=corentincj@iksaif.net \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.