From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <neko@genesi-usa.com>
Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.157])
	by ozlabs.org (Postfix) with ESMTP id 14855DE170
	for <linuxppc-dev@ozlabs.org>; Thu, 27 Mar 2008 09:57:36 +1100 (EST)
Received: by fg-out-1718.google.com with SMTP id 16so3212373fgg.39
	for <linuxppc-dev@ozlabs.org>; Wed, 26 Mar 2008 15:57:34 -0700 (PDT)
Message-ID: <47EAD4DA.5050907@genesi-usa.com>
Date: Wed, 26 Mar 2008 22:57:30 +0000
From: Matt Sealey <matt@genesi-usa.com>
MIME-Version: 1.0
To: Grant Likely <grant.likely@secretlab.ca>,
	Matt Sealey <matt@genesi-usa.com>,
	linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
	Anatolij Gustschin <agust@denx.de>
Subject: Re: [RESEND][POWERPC] mpc5200: Amalgamated dts fixes and updates
References: <47E2723D.1090101@grandegger.com> <47E281B6.20702@denx.de>
	<fa686aa40803201650t289cd800gfda389b192c1834c@mail.gmail.com>
	<47E2FC3E.1020705@semihalf.com>
	<fa686aa40803201720l3e42c983se121ebc257c89912@mail.gmail.com>
	<20080321235633.GB345@frozen.semihalf.com>
	<fa686aa40803212014ne560615sfcdef542d59eb6cb@mail.gmail.com>
	<20080326194526.GA17424@frozen.semihalf.com>
	<47EAB9CC.7060002@genesi-usa.com>
	<fa686aa40803261416s38164c98ua774731eadc1f85f@mail.gmail.com>
	<20080326225128.GB5777@localhost.localdomain>
In-Reply-To: <20080326225128.GB5777@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Sender: Matt Sealey <neko@genesi-usa.com>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

David Gibson wrote:
> On Wed, Mar 26, 2008 at 03:16:47PM -0600, Grant Likely wrote:
>> On Wed, Mar 26, 2008 at 3:02 PM, Matt Sealey <matt@genesi-usa.com> wrote:
>>> Bartlomiej Sieka wrote:
>>>  > +
>>>  > +                     phy0:ethernet-phy@0 {
>>>  > +                             device_type = "ethernet-phy";@0"
>>>  > +                             reg = <0>;
>>>  > +                     };
>>>
>>>  What's the parsing of this pan out to? What does it mean?
>>>
>>>  Having colons in device names is totally contrary to OF device naming
>>>  spec. Does the part after the colon have a special meaning to the DTC?
>> "phy0:" is a label used by dtc.
>> "ethernet-phy@0" is the node name.
> 
> I would suggest a space after the colon though, to make this clearer.
> That's the style I've been using in all my dts files.

I would suggest taking a hint from C structures...

ethernet-phy@0 {
	name = "ethernet-phy";
	reg = <0>;
	foo = bar;
} phy0;

I mean, this is really intuitive, we all do this every day...

-- 
Matt Sealey <matt@genesi-usa.com>
Genesi, Manager, Developer Relations