All of lore.kernel.org
 help / color / mirror / Atom feed
* [Xenomai-core] [SOLO] [PATCH] Obtain proper prefix for testsuite build
@ 2008-03-26 14:36 jserv
  2008-03-27  0:03 ` Philippe Gerum
  0 siblings, 1 reply; 3+ messages in thread
From: jserv @ 2008-03-26 14:36 UTC (permalink / raw)
  To: xenomai

Hello list,

  Currently, Xenomai/SOLO comes with testsuite for VxWorks emulation.
The path to Xenomai/SOLO installation is fixed.  The patch attempts to
obtain the proper prefix during build process.

Regards,
-jserv

diff --git a/vxworks/testsuite/Makefile b/vxworks/testsuite/Makefile
index 62430ff..13ca9a0 100644
--- a/vxworks/testsuite/Makefile
+++ b/vxworks/testsuite/Makefile
@@ -1,4 +1,4 @@
-SOLO := /usr/local/solo
+SOLO := $(shell sed -n '/^prefix/'p ../Makefile | cut -c 9-)
 XENO_CONFIG=$(SOLO)/bin/xeno-config
 prefix := $(shell $(XENO_CONFIG) --prefix)


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Xenomai-core] [SOLO] [PATCH] Obtain proper prefix for testsuite build
  2008-03-26 14:36 [Xenomai-core] [SOLO] [PATCH] Obtain proper prefix for testsuite build jserv
@ 2008-03-27  0:03 ` Philippe Gerum
  2008-03-28 12:10   ` jserv
  0 siblings, 1 reply; 3+ messages in thread
From: Philippe Gerum @ 2008-03-27  0:03 UTC (permalink / raw)
  To: jserv; +Cc: xenomai

jserv@domain.hid wrote:
> Hello list,
> 
>   Currently, Xenomai/SOLO comes with testsuite for VxWorks emulation.
> The path to Xenomai/SOLO installation is fixed.  The patch attempts to
> obtain the proper prefix during build process.
> 
> Regards,
> -jserv
> 
> diff --git a/vxworks/testsuite/Makefile b/vxworks/testsuite/Makefile
> index 62430ff..13ca9a0 100644
> --- a/vxworks/testsuite/Makefile
> +++ b/vxworks/testsuite/Makefile
> @@ -1,4 +1,4 @@
> -SOLO := /usr/local/solo
> +SOLO := $(shell sed -n '/^prefix/'p ../Makefile | cut -c 9-)
>  XENO_CONFIG=$(SOLO)/bin/xeno-config
>  prefix := $(shell $(XENO_CONFIG) --prefix)
>

This won't work if you build out of the source tree like autoconf/automake
recommend, since it won't find the instantiated Makefile in the upper directory.
We could use an autoconf template to patch the prefix into
testsuite/Makefile.in, but the testsuite/ directory is meant to be movable and
compilable anywhere the user sees fit. This is basically why the Makefile has
not been autoconfiscated in the first place.

I guess we will have to leave with the "set your Xenomai install directory for
scripts and binaries in your PATH variable" rule. I have removed the absolute
SOLO prefix from the Makefile though, it was a left over from my development
environment.

Thanks for spotting this.

-- 
Philippe.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Xenomai-core] [SOLO] [PATCH] Obtain proper prefix for testsuite build
  2008-03-27  0:03 ` Philippe Gerum
@ 2008-03-28 12:10   ` jserv
  0 siblings, 0 replies; 3+ messages in thread
From: jserv @ 2008-03-28 12:10 UTC (permalink / raw)
  To: Philippe Gerum; +Cc: xenomai

On Thu, Mar 27, 2008 at 01:03:37AM +0100, Philippe Gerum wrote:
> This won't work if you build out of the source tree like autoconf/automake
> recommend, since it won't find the instantiated Makefile in the upper directory.
> We could use an autoconf template to patch the prefix into
> testsuite/Makefile.in, but the testsuite/ directory is meant to be movable and
> compilable anywhere the user sees fit. This is basically why the Makefile has
> not been autoconfiscated in the first place.

hi Philippe,

Indeed.  It was just my dirty hack.  Thanks for pointing out the
details.

> I guess we will have to leave with the "set your Xenomai install directory for
> scripts and binaries in your PATH variable" rule. I have removed the absolute
> SOLO prefix from the Makefile though, it was a left over from my development
> environment.

Good instructions. :-)

Regards,
-jserv


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-03-28 12:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-26 14:36 [Xenomai-core] [SOLO] [PATCH] Obtain proper prefix for testsuite build jserv
2008-03-27  0:03 ` Philippe Gerum
2008-03-28 12:10   ` jserv

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.