From: Geoff Levand <geoffrey.levand@am.sony.com>
To: paulus@samba.org
Cc: linuxppc-dev@ozlabs.org, Roel Kluin <12o3l@tiscali.nl>
Subject: [patch 1/6] PS3: Fix unlikely typo in ps3_get_irq
Date: Wed, 26 Mar 2008 17:37:18 -0700 [thread overview]
Message-ID: <47EAEC3E.1050006@am.sony.com> (raw)
In-Reply-To: <20080327001821.827672589@am.sony.com>
From: Roel Kluin <12o3l@tiscali.nl>
Fix a typo bug 'unlikely(x) == y' and add an unlikely() call to
an unlikely code path in the PS3 interrupt routine ps3_get_irq().
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
arch/powerpc/platforms/ps3/interrupt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/powerpc/platforms/ps3/interrupt.c
+++ b/arch/powerpc/platforms/ps3/interrupt.c
@@ -709,7 +709,7 @@ static unsigned int ps3_get_irq(void)
asm volatile("cntlzd %0,%1" : "=r" (plug) : "r" (x));
plug &= 0x3f;
- if (unlikely(plug) == NO_IRQ) {
+ if (unlikely(plug == NO_IRQ)) {
pr_debug("%s:%d: no plug found: thread_id %lu\n", __func__,
__LINE__, pd->thread_id);
dump_bmp(&per_cpu(ps3_private, 0));
--
next parent reply other threads:[~2008-03-27 0:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080327001821.827672589@am.sony.com>
2008-03-27 0:37 ` Geoff Levand [this message]
2008-03-27 0:37 ` [patch 2/6] PS3: Add ps3_get_speid routine Geoff Levand
2008-03-27 0:38 ` [patch 3/6] PS3: Bootwrapper improvements Geoff Levand
2008-03-27 8:13 ` Geert Uytterhoeven
2008-03-27 20:41 ` [patch 3/6 v2] " Geoff Levand
2008-03-27 0:38 ` [patch 4/6] PS3: Save power in busy loops on halt Geoff Levand
2008-03-27 0:39 ` [patch 5/6] PS3: Sys-manager Wake-on-LAN support Geoff Levand
2008-03-27 0:53 ` Benjamin Herrenschmidt
2008-03-27 1:04 ` Geoff Levand
2008-03-27 0:39 ` [patch 6/6] PS3: Gelic network driver " Geoff Levand
2008-03-28 21:59 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EAEC3E.1050006@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=12o3l@tiscali.nl \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.