All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toby Corkindale <toby.corkindale@rea-group.com>
To: git@vger.kernel.org
Subject: Re: .git/info/attributes not cloned
Date: Thu, 27 Mar 2008 15:48:31 +1100	[thread overview]
Message-ID: <47EB271F.1050307@rea-group.com> (raw)
In-Reply-To: <20080327042925.GA6426@coredump.intra.peff.net>

Jeff King wrote:
> On Thu, Mar 27, 2008 at 03:23:27PM +1100, Toby Corkindale wrote:
> 
>> Ah, OK.
>> I was hoping not to use .gitattributes, as then the attributes are  
>> ignored when doing something like:
>> git archive --remote=example.com:/path/to/repo release/v2.1 | tar xf -
> 
> I vaguely recall some discussion of this in the past, so maybe it isn't
> a good idea. But I would think changing git-archive to respect
> .gitattributes might be worth doing (presumably the version of
> .gitattributes from the tree that is being exported).

Respecting the repo's .gitattributes would feel right. It seems unusual 
(to me) that it bypasses $REMOTE/.gitattributes, but DOES check 
$REMOTE/info/attributes.


>> That gives a clue that the /info/ files are repo-specific.
>> However in gitignore(5) and gitattributes(5), there is no explanation of  
>> this - it simply mentions that the info version is a higher priority than 
>> the .git{ignore,attributes} version.
>>
>> I suggest that the individual docs/man-pages should mention that too.
>> I'll submit a patch in a separate email, as long as I'm not still  
>> misunderstanding the mechanism.
> 
> I think you understand what is going on. A clarification to both pages
> would be helpful, I think, just saying "here is why you might use one
> over the other."

Cheers. I've submitted my patch now. I hope I have the doc syntax right.

>> Is there a recommended way to make attributes apply to commands run on a  
>> remote repository, or is that a different bug?
> 
> I'm not sure what you mean here. Very few commands talk to remote
> repositories. I had assumed in your git-archive example that you wanted
> .gitattributes on the remote repo to affect the tarfile generated by
> that repo. But now it sounds like you want to edit a local file to
> impact the archive generated remotely. I don't think there is a way to
> do that.

Ah, no, you were right in your first assumption. I just wanted 
git-archive to apply gitattributes to the resulting tarball.
(I should have phrased that last line as "..apply to commands connecting 
to a remote repo.." and it would make more sense.)

thanks,
Toby

  reply	other threads:[~2008-03-27  4:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27  3:08 .git/info/attributes not cloned Toby Corkindale
2008-03-27  3:33 ` Jeff King
2008-03-27  4:23   ` Toby Corkindale
2008-03-27  4:29     ` Jeff King
2008-03-27  4:48       ` Toby Corkindale [this message]
2008-03-27  4:53         ` Jeff King
2008-03-28  5:10           ` [BUG?] git-archive ignores remote .gitattributes (was: .git/info/attributes not cloned) Toby Corkindale
2008-03-28 12:22             ` Johannes Schindelin
2008-03-28 13:02               ` Jakub Narebski
2008-03-28 13:22                 ` Johannes Schindelin
2008-03-31  2:47               ` Jeff King
2008-03-31  3:07                 ` [BUG?] git-archive ignores remote .gitattributes Junio C Hamano
2008-04-10  4:14               ` Toby Corkindale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47EB271F.1050307@rea-group.com \
    --to=toby.corkindale@rea-group.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.