Kevin Wolf schrieb: > What should we do with the tapdisk implementation? Leave it broken and > hope that it will disappear soon, add support for big endian L1 tables > or do a conversion the other way round? The latter doesn't feel right > (in fact it would be intentionally breaking a correct image), but adding > support for big endian is much more critical because we end up with > "mixed endian" if we miss one conversion... And another one for tapdisk. I'm taking the same approach as for ioemu here, i.e. converting the endianess when the image is opened and rewriting the tapdisk code to use big endian. To avoid the mentioned "mixed endian" issue and thus data corruption, please double check the patch before you check it in. I successfully installed a VM with this patch, though, so I'm confident that it is correct. Kevin tapdisk: Fix L1 table endianess of qcow images Fix tapdisk to use big endian L1 tables as used by qemu/ioemu. Old tapdisk images with native endianess are automagically converted to big endian when the image file is opened for the first time. Signed-off-by: Kevin Wolf