From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jf03c-0007RC-3V for mharc-grub-devel@gnu.org; Thu, 27 Mar 2008 17:54:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jf03a-0007OH-Mk for grub-devel@gnu.org; Thu, 27 Mar 2008 17:54:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jf03Z-0007Ky-6L for grub-devel@gnu.org; Thu, 27 Mar 2008 17:54:46 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jf03Y-0007Kf-W8 for grub-devel@gnu.org; Thu, 27 Mar 2008 17:54:45 -0400 Received: from pne-smtpout3-sn2.hy.skanova.net ([81.228.8.111]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jf03Y-0003Lf-8C for grub-devel@gnu.org; Thu, 27 Mar 2008 17:54:44 -0400 Received: from [127.0.0.1] (88.193.32.97) by pne-smtpout3-sn2.hy.skanova.net (7.3.129) id 478BDB96003F452C for grub-devel@gnu.org; Thu, 27 Mar 2008 22:54:39 +0100 Message-ID: <47EC17BA.2020507@nic.fi> Date: Thu, 27 Mar 2008 23:55:06 +0200 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: The development of GRUB 2 References: <20080326220948.xw0fmregqocog0s0@webmail.spamcop.net> <1206631822.2380.2.camel@dv> <1206650930.7377.16.camel@dv> <1206654363.10959.11.camel@dv> In-Reply-To: <1206654363.10959.11.camel@dv> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) Subject: Re: Native CD test results X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2008 21:54:47 -0000 Pavel Roskin wrote: > On Thu, 2008-03-27 at 16:48 -0400, Pavel Roskin wrote: >> On Fri, 2008-03-28 at 04:25 +0800, Bean wrote: >> >>> This patch add support for 16-bit png. >> Thanks was quick! It's working for me. > > By the way, we should recognize images by their internal data, not by > the filenames. As it stands now, the jpeg reader only supports files > with ".jpeg" extension, not with ".jpg", which is more popular. And the > error message is unclear if the extension is unknown. .jpg should of course be supported. But why we _should_ support others (incorrectly named files) ? I think file extension is good enough to detect images... If someone makes incorrect extensions its their problem... we just make sure our driver do not die at that...