From: Roel Kluin <12o3l@tiscali.nl>
To: sfr@canb.auug.org.au
Cc: linux-laptop@vger.kernel.org
Subject: hp6xx: Test APM_DISABLED bit or definition in hp6x0_apm_interrupt()?
Date: Fri, 28 Mar 2008 00:35:13 +0100 [thread overview]
Message-ID: <47EC2F31.9020107@tiscali.nl> (raw)
from arch/sh/boards/hp6xx/hp6xx_apm.c:78
static irqreturn_t hp6x0_apm_interrupt(int irq, void *dev)
{
if (!APM_DISABLED)
apm_queue_event(APM_USER_SUSPEND);
return IRQ_HANDLED;
}
shouldn't that be something like
if (!(apm_info.bios.flags & APM_DISABLED))
considering that APM_DISABLED is defined in include/linux/apm_bios.h:153:
#define APM_DISABLED 0x01
reply other threads:[~2008-03-27 23:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EC2F31.9020107@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=linux-laptop@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.