From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: chrisw@sous-sol.org, sct@redhat.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, xen-ia64-devel@lists.xensource.com,
eddie.dong@intel.com
Subject: Re: [PATCH 07/12] Xen: Make events.c portable for ia64/xen support.
Date: Fri, 28 Mar 2008 13:27:58 -0700 [thread overview]
Message-ID: <47ED54CE.7000007@goop.org> (raw)
In-Reply-To: <12067044180-git-send-email-yamahata@valinux.co.jp>
Isaku Yamahata wrote:
> +/* macro to avoid header inclusion dependncy hell */
> +#define xen_irqs_disabled(regs) (!((regs)->flags & X86_EFLAGS_IF))
>
This seems pretty generic. Is there no suitable existing function?
Could irqs_disabled_flags() be pressed into service? I guess it depends
on how ia64 (and other architectures) can get the saved flags state from
the interrupt context.
> +
> +/* macro to avoid header inclusion dependncy hell */
> +#define xen_do_IRQ(irq, regs) \
> + do { \
> + (regs)->orig_ax = ~(irq); \
> + do_IRQ(regs); \
> + } while (0)
>
It's not possible to put this somewhere it could be an inline function?
It might be better to make it an out of line function then.
J
next prev parent reply other threads:[~2008-03-28 20:28 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 11:40 [PATCH 00/12] Xen arch portability patches (take 4) Isaku Yamahata
2008-03-28 11:40 ` [PATCH 01/12] xen: add missing __HYPERVISOR_arch_[0-7] definisions which ia64 needs Isaku Yamahata
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 11:40 ` [PATCH 02/12] xen: add missing VIRQ_ARCH_[0-7] definitions which ia64/xen needs Isaku Yamahata
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 11:40 ` [PATCH 03/12] xen: add missing definitions for xen grant table " Isaku Yamahata
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 11:40 ` [PATCH 04/12] xen: add missing definitions in include/xen/interface/vcpu.h " Isaku Yamahata
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 11:40 ` [PATCH 05/12] xen: move features.c from arch/x86/xen/features.c to drivers/xen Isaku Yamahata
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 11:40 ` [PATCH 06/12] xen: Move events.c to drivers/xen for IA64/Xen support Isaku Yamahata
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 11:40 ` [PATCH 07/12] Xen: Make events.c portable for ia64/xen support Isaku Yamahata
2008-03-28 20:27 ` Jeremy Fitzhardinge [this message]
2008-03-31 9:34 ` Isaku Yamahata
2008-03-31 9:34 ` Isaku Yamahata
2008-03-28 20:27 ` Jeremy Fitzhardinge
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 11:40 ` [PATCH 08/12] xen: add resend_irq_on_evtchn() definition into events.c Isaku Yamahata
2008-03-28 20:29 ` Jeremy Fitzhardinge
2008-03-28 20:29 ` Jeremy Fitzhardinge
2008-03-31 9:36 ` Isaku Yamahata
2008-03-31 9:36 ` Isaku Yamahata
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 11:40 ` [PATCH 09/12] xen: make include/xen/page.h portable moving those definitions under asm dir Isaku Yamahata
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 20:41 ` Jeremy Fitzhardinge
2008-03-30 13:41 ` Avi Kivity
2008-03-30 13:41 ` Avi Kivity
2008-03-28 20:41 ` Jeremy Fitzhardinge
2008-03-28 11:40 ` [PATCH 10/12] xen: replace callers of alloc_vm_area()/free_vm_area() with xen_ prefixed one Isaku Yamahata
2008-03-28 20:31 ` Jeremy Fitzhardinge
2008-03-28 20:31 ` Jeremy Fitzhardinge
2008-03-31 10:11 ` Isaku Yamahata
2008-03-31 10:11 ` Isaku Yamahata
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 11:40 ` [PATCH 11/12] xen: make grant table arch portable Isaku Yamahata
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 11:40 ` [PATCH 12/12] xen: import arch generic part of xencomm Isaku Yamahata
2008-03-28 11:40 ` Isaku Yamahata
2008-03-28 20:09 ` Jeremy Fitzhardinge
2008-03-28 20:09 ` Jeremy Fitzhardinge
2008-03-31 9:49 ` Isaku Yamahata
2008-03-31 15:01 ` Jeremy Fitzhardinge
2008-03-31 15:01 ` Jeremy Fitzhardinge
2008-03-31 9:49 ` Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ED54CE.7000007@goop.org \
--to=jeremy@goop.org \
--cc=chrisw@sous-sol.org \
--cc=eddie.dong@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-ia64-devel@lists.xensource.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.