From: Tejun Heo <htejun@gmail.com>
To: akpm@linux-foundation.org
Cc: jeff@garzik.org, linux-ide@vger.kernel.org
Subject: Re: [patch 1/3] git-libata: fix CONFIG_PCI=n build
Date: Sat, 29 Mar 2008 10:04:19 +0900 [thread overview]
Message-ID: <47ED9593.3040100@gmail.com> (raw)
In-Reply-To: <200803282133.m2SLXj7h011457@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> sh allmodconfig:
>
> drivers/ata/libata-core.c:127: error: `ata_pci_default_filter' undeclared here (not in a function)
> drivers/ata/libata-core.c:127: error: initializer element is not constant
> drivers/ata/libata-core.c:127: error: (near initialization for `ata_bmdma_port_ops.mode_filter')
>
> Cc: Tejun Heo <htejun@gmail.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
There's a pending patch to pull ata_pci_default_filter() out of
CONFIG_PCI as there's nothing PCI specific about it but this is a
correct fix. Jeff, if you're gonna merge the modularize-SFF patchset,
this one isn't necessary. If not, please go ahead and merge this.
Thanks.
--
tejun
prev parent reply other threads:[~2008-03-29 1:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 21:33 [patch 1/3] git-libata: fix CONFIG_PCI=n build akpm
2008-03-29 1:04 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ED9593.3040100@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.