From: Jarek Poplawski <jarkao2@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: David Miller <davem@davemloft.net>,
davej@codemonkey.org.uk, netdev@vger.kernel.org
Subject: Re: 2.6.25rc7 lockdep trace
Date: Sat, 29 Mar 2008 13:52:28 +0100 [thread overview]
Message-ID: <47EE3B8C.8090707@gmail.com> (raw)
In-Reply-To: <1206784948.22530.128.camel@johannes.berg>
Johannes Berg wrote, On 03/29/2008 11:02 AM:
...
> When you call cancel_work_sync(), the work struct will be grabbed by the
> code (really __cancel_work_timer) and removed from the queue. That just
> operates on bits and a spinlock, not locks held across the struct work
> function execution, and ensures it is race-free without needing any such
> locks
...
> However, as I just tried to explain, cancel_work_sync() _is_ safe to run
> while holding the RTNL because it doesn't need any runqueue lock.
These issues are so seldom now that I forget these details each time
"after use", so maybe I miss something again, but shouldn't this rather
read something like this?:
cancel_work_sync() _is_ safe to run while holding the RTNL against
works which don't take RTNL.
Regards,
Jarek P.
next prev parent reply other threads:[~2008-03-29 12:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 0:00 2.6.25rc7 lockdep trace Dave Jones
2008-03-28 1:55 ` Dave Jones
2008-03-29 0:34 ` David Miller
2008-03-29 0:54 ` Johannes Berg
2008-03-29 1:01 ` Johannes Berg
2008-03-29 1:09 ` David Miller
2008-04-02 8:51 ` Oleg Nesterov
2008-03-29 1:06 ` David Miller
2008-03-29 10:02 ` Johannes Berg
2008-03-29 12:52 ` Jarek Poplawski [this message]
2008-03-29 12:50 ` Johannes Berg
2008-04-03 20:48 ` David Miller
2008-04-04 14:48 ` Johannes Berg
2008-06-11 5:40 ` David Miller
2008-06-11 7:08 ` Jarek Poplawski
2008-06-11 7:10 ` David Miller
2008-06-11 9:36 ` Jarek Poplawski
2008-06-12 0:34 ` David Miller
2008-06-12 6:29 ` Jarek Poplawski
2008-06-11 10:40 ` Jarek Poplawski
2008-06-12 0:31 ` David Miller
2008-06-11 13:14 ` Jarek Poplawski
2008-06-12 5:46 ` David Miller
2008-06-12 7:20 ` Johannes Berg
2008-06-12 8:23 ` David Miller
2008-06-12 6:13 ` Jarek Poplawski
2008-06-12 7:01 ` David Miller
2008-06-12 7:47 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EE3B8C.8090707@gmail.com \
--to=jarkao2@gmail.com \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.