Re: [patch 3/3] ata: SWNCQ should be enabled by default

[Tejun Heo <htejun@gmail.com>]

Robert Hancock wrote:
> Tejun Heo wrote:
>> Zoltan Boszormenyi wrote:
>>> Tejun Heo írta:
>>>> akpm@linux-foundation.org wrote:
>>>>> From: Zoltan Boszormenyi <zboszor@dunaweb.hu>
>>>>>
>>>>> unchangelogged patch.
>>>>>
>>>>> Signed-off-by: Zoltan Boszormenyi <zboszor@dunaweb.hu>
>>>>> Cc: Robert Hancock <hancockr@shaw.ca>
>>>>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>>>>
>>>> Nacked-by: Tejun Heo <htejun@gmail.com>
>>>>
>>>> Sorry, there are remaining issues to resolve before enabling ADMA by 
>>>> default.
>>>
>>> Sorry, this is NOT ADMA. SWNCQ is completely independent from ADMA.
>>
>> Heh, right.  Sorry about that.  I disabled ADMA on the distro I work 
>> for and somehow ADMA was disabled on mainline too.  :-)
>>
>> Robert, is SWNCQ safe to turn on by default?  I personally think it's 
>> better to prefer safety over performance or optional features and 
>> given the history of NCQ support on nv satas, I feel a bit more cautious.
>>
>> Maybe we can enable SWNCQ on -mm and devel branches and disable it 
>> late in release cycle for 2.6.26 for a trial?
> 
> I haven't seen any problem reports, but with it disabled by default most 
> people haven't tried it. The only way to really know is to try turning 
> it on by default and see what shakes out.
> 
> I'd vote to enable it by default in -mm and 2.6.26-rc and see what happens.

Alright, Zoltan can you please repost w/ commit message fixed and 
comment stating /* FIXME: for testing during blah blah */ added?

-- 
tejun