All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <bwarren@qstreams.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] ColdFire: Fix FEC transmit issue for MCF5275
Date: Sun, 30 Mar 2008 00:18:15 -0400	[thread overview]
Message-ID: <47EF1487.4000003@qstreams.com> (raw)
In-Reply-To: <1205791696-17263-1-git-send-email-Tsi-Chung.Liew@freescale.com>

Tsi-Chung Liew wrote:
> Signed-off-by: TsiChung Liew <Tsi-Chung.Liew@freescale.com>
> ---
>  drivers/net/mcffec.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/mcffec.c b/drivers/net/mcffec.c
> index 3b81258..71d1960 100644
> --- a/drivers/net/mcffec.c
> +++ b/drivers/net/mcffec.c
> @@ -166,6 +166,13 @@ int fec_send(struct eth_device *dev, volatile void *packet, int length)
>  	/* Activate transmit Buffer Descriptor polling */
>  	fecp->tdar = 0x01000000;	/* Descriptor polling active    */
>  
> +	/* FEC fix for MCF5275, FEC unable to initial transmit data packet.
> +	 * A nop will ensure the descriptor polling active completed.
> +	 */
> +#ifdef CONFIG_M5275
> +	__asm__ ("nop");
> +#endif
> +
>  #ifdef CFG_UNIFY_CACHE
>  	icache_invalid();
>  #endif
>   
Applied to net tree. As others have noted, adding a NOP here seems like 
a band-aid, but I can't really dispute it.

thanks,
Ben

  parent reply	other threads:[~2008-03-30  4:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17 22:08 [U-Boot-Users] [PATCH] ColdFire: Fix FEC transmit issue for MCF5275 Tsi-Chung Liew
2008-03-18 21:29 ` Wolfgang Denk
2008-03-30  4:18 ` Ben Warren [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-03-18 22:29 Tsi-Chung Liew
2008-03-19 14:05 ` Jon Loeliger
2008-03-19 15:18   ` Scott Wood
2008-03-20  0:55 Tsi-Chung Liew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47EF1487.4000003@qstreams.com \
    --to=bwarren@qstreams.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.