All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger C. Soares" <rogersoares@intelinet.com.br>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, robin.rosenberg@dewire.com
Subject: Re: [EGIT PATCH 1/4] Change history page table to SWT.VIRTUAL.
Date: Tue, 01 Apr 2008 00:54:01 -0300	[thread overview]
Message-ID: <47F1B1D9.3090209@intelinet.com.br> (raw)
In-Reply-To: <20080401033614.GP10274@spearce.org>


Shawn O. Pearce escreveu:
> So anyway, I see no breakage on Mac OS X or Win32 with your patch,
> and you said you tested it on Linux, so I'm going to include it.
> Thanks for figuring that one out, its a nice performance boost.
>   
Cool.


>> Maybe another option to try before leaving windows out is the 
>> ILazyContentProvider. Have you noticed that while GenerateHistoryJob is 
>> updating the table you can't use it? Because the input is regenerated 
>> every time, the table keeps going back to the first row.
>>     
>
> Hmm.  I didn't notice that, but at this point its so damn fast for
> me that I don't have the reflexes to really try and use the table
> before GenerateHistoryJob is complete.  I'll have to add some sleeps
> in there to make it slow down its work and see if I can reproduce
> what you are describing.
>   
Yep, I noticed it while debuging and don't think it's very important. 
I'm very happy with the current speed and it's also almost instant to 
me. I think the lazy provider could be of some help in case someone is 
reading from a slow nfs partition or something like that. It's very 
border case thought.

[]s,
Roger.

  reply	other threads:[~2008-04-01  3:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-30 15:18 [EGIT PATCH 1/4] Change history page table to SWT.VIRTUAL Roger C. Soares
2008-03-31  5:34 ` Shawn O. Pearce
2008-04-01  3:25   ` Roger C. Soares
2008-04-01  3:36     ` Shawn O. Pearce
2008-04-01  3:54       ` Roger C. Soares [this message]
2008-04-01  4:12         ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F1B1D9.3090209@intelinet.com.br \
    --to=rogersoares@intelinet.com.br \
    --cc=git@vger.kernel.org \
    --cc=robin.rosenberg@dewire.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.