Re: [PATCH] scsi: ch.c fix sparse shadowed variable warnings

[Boaz Harrosh <bharrosh@panasas.com>]

On Tue, Apr 01 2008 at 17:51 +0300, James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Mon, 2008-03-31 at 22:05 -0700, Harvey Harrison wrote:
>> Replace the global err array with ch_err.
>> drivers/scsi/ch.c:271:6: warning: symbol 'err' shadows an earlier one
>> drivers/scsi/ch.c:116:3: originally declared here
>>
>> Replace the temporary cmd buffer with ch_err to avoid shadowing the cmd
>> function parameter.
>> drivers/scsi/ch.c:724:11: warning: symbol 'cmd' shadows an earlier one
>> drivers/scsi/ch.c:596:20: originally declared here
>>
>> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
>> ---
>> James, incorporated your comments.
> 
> Yes, that looks fine, thanks.
> 
> I have a challenge for you:  It looks like this driver has three
> incorrect unconditional uses of GFP_DMA.  It gets a 512 byte bufer and
> then only uses 256 bytes of it on several occasions and the routine with
> the shadowed cmd variable looks like it should be calling
> ch_read_element_status() rather than duplicating it.
> 
> James
> 
I have the GFP_DMA and allocation stuff covered for this driver.

Boaz