From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix fdt set command to conform to dts spec
Date: Wed, 02 Apr 2008 11:29:36 -0400 [thread overview]
Message-ID: <47F3A660.2060804@gmail.com> (raw)
In-Reply-To: <1207014356-1663-1-git-send-email-afleming@freescale.com>
Andy Fleming wrote:
> The fdt set command was treating properties specified as <00> and <0011>
> as byte streams, rather than as an array of cells. As we already have
> syntax for expressing the desire for a stream of bytes ([ xx xx ...]),
> we should use the <> syntax to describe arrays of cells, which are always
> 32-bits per element. If we imagine this likely (IMHO) scenario:
>
>> fdt set /ethernet-phy at 1 reg <1>
>
> With the old code, this would create a bad fdt, since the reg cell would be
> made to be one byte in length. But the cell must be 4 bytes, so this would
> break mysteriously.
Confirmed, my bad. Applied to the u-boot-fdt repo.
Thanks,
gvb
prev parent reply other threads:[~2008-04-02 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 1:45 [U-Boot-Users] [PATCH] Fix fdt set command to conform to dts spec Andy Fleming
2008-04-01 14:06 ` Jerry Van Baren
2008-04-02 15:29 ` Jerry Van Baren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F3A660.2060804@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.