From: "H. Peter Anvin" <hpa@zytor.com>
To: Paul Jackson <pj@sgi.com>
Cc: "Huang, Ying" <ying.huang@intel.com>,
andi@firstfloor.org, mingo@redhat.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct setup_data
Date: Wed, 02 Apr 2008 09:39:18 -0700 [thread overview]
Message-ID: <47F3B6B6.9010802@zytor.com> (raw)
In-Reply-To: <20080402023947.d4d43f7d.pj@sgi.com>
Paul Jackson wrote:
> Huang wrote:
>> On Sat, 2008-03-29 at 23:31 -0500, Paul Jackson wrote:
>>> Huang wrote:
>>>> +/* setup data types */
>>>> +#define SETUP_NONE 0
>>> This define seems unused?
>> I think this can prevent somebody to use 0 as type id.
>
> Why is it a good idea to prevent a 0 type id?
>
It is usually handy to have an ID to use as ignore, or not present, and
for that to be zero.
-hpa
next prev parent reply other threads:[~2008-04-02 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 2:49 [PATCH 2/4] x86_64 boot -v2: Add linked list of struct setup_data Huang, Ying
2008-03-30 4:25 ` Paul Jackson
2008-03-30 4:31 ` Paul Jackson
2008-03-31 0:54 ` Huang, Ying
2008-04-02 7:39 ` Paul Jackson
2008-04-02 16:39 ` H. Peter Anvin [this message]
2008-04-02 17:36 ` Paul Jackson
2008-03-30 8:15 ` Yinghai Lu
2008-03-31 0:52 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F3B6B6.9010802@zytor.com \
--to=hpa@zytor.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pj@sgi.com \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.