From: Avi Kivity <avi@qumranet.com>
To: Matteo Frigo <athena@fftw.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] QEMU/KVM SCSI lock up
Date: Thu, 03 Apr 2008 14:49:02 +0300 [thread overview]
Message-ID: <47F4C42E.3050301@qumranet.com> (raw)
In-Reply-To: <87d4p7i3tx.fsf@fftw.org>
Matteo Frigo wrote:
> Avi Kivity <avi@qumranet.com> writes:
>
>
>> Will that not issue the read for the wrong sector?
>>
>
> The patch that I submitted issues the read for the correct sector:
> It reads (r->sector - n) instead of r->sector. I apologize
> if my explanation of the patch was confusing on this point.
>
>
I misread the patch, sorry.
>> I think the correct fix is to move r->sector and r->sector_count
>> adjustment into scsi_read_complete() and scsi_write_complete().
>>
>
> This will work as long as you can guarantee that scsi_read_complete()
> is called before the recursive call to scsi_read_data().
Yes, scsi_read_complete() calls s->completion, which triggers the
recursion, by my reading.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-04-03 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 0:41 [Qemu-devel] QEMU/KVM SCSI lock up Matteo Frigo
2008-04-03 8:38 ` Avi Kivity
2008-04-03 11:18 ` Matteo Frigo
2008-04-03 11:49 ` Avi Kivity [this message]
2008-04-03 11:31 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F4C42E.3050301@qumranet.com \
--to=avi@qumranet.com \
--cc=athena@fftw.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.