From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 04/24] [NETFILTER]: remove unused ARPT_ALIGN indirection macros Date: Thu, 03 Apr 2008 14:38:31 +0200 Message-ID: <47F4CFC7.1040200@trash.net> References: <1207134726-28689-1-git-send-email-jengelh@computergmbh.de> <47F4C439.9080204@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:33138 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbYDCMii (ORCPT ); Thu, 3 Apr 2008 08:38:38 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jan Engelhardt wrote: > > On Thursday 2008-04-03 13:49, Patrick McHardy wrote: >> Jan Engelhardt wrote: >>> Signed-off-by: Jan Engelhardt >>> --- >>> include/linux/netfilter_arp/arp_tables.h | 4 ---- >>> 1 files changed, 0 insertions(+), 4 deletions(-) >>> >>> diff --git a/include/linux/netfilter_arp/arp_tables.h >>> b/include/linux/netfilter_arp/arp_tables.h >>> index 0e6b5e1..1cb698b 100644 >>> --- a/include/linux/netfilter_arp/arp_tables.h >>> +++ b/include/linux/netfilter_arp/arp_tables.h >>> @@ -274,8 +274,6 @@ extern unsigned int arpt_do_table(struct sk_buff >>> *skb, >>> const struct net_device *out, >>> struct xt_table *table); >>> >>> -#define ARPT_ALIGN(s) XT_ALIGN(s) >> >> This is exported to userspace, so I can't apply this. I'm >> also reverting 03/24 since that also breaks userspace. > > I would not expect anything but arptables to use these macros; > and actually arptables has its own copies of the .h files much > like iptables does. Just my 13 cents. I wouldn't be so sure of that, there also have been other programs using the iptables API, besides the fact that arptables can also be compiled against the current headers. Speculation is not enough for breaking an interface, sorry.