Keir Fraser wrote:
>>> NUMA_NO_NODE probably needs to be pulled out of asm-x86/numa.h and made the
>>> official arch-neutral way to specify 'don't care' for numa nodes.
>> Is this really needed? I provided memflags=0 is all don't care cases,
>> this should work and is more compatible. But beware that this silently
>> assumes in page_alloc.c#alloc_domheap_pages that NUMA_NO_NODE is 0xFF,
>> otherwise this trick will not work.
> 
> Yes it is needed if your patch is to work across all architectures, not just
> x86! Your current patch is broken in this respect because you quite
> unnecessarily define domain_to_node() and vcpu_to_node() in asm/numa.h
> rather than xen/numa.h.
Right you are. I fixed this below. While playing around with the 
headers, I realized that numa.h is not needed at all in 
common/page_alloc.c and common/sysctl.c. Can you confirm this? Or is 
this needed for the other architectures?

Signed-off-by: Andre Przywara <andre.przywara@amd.com>


> Please address architectural portability and re-send the patch. Apart from
> that I think it's just about ready to go in.
I am just trying to install an IA64 cross compiler, but it seems this 
will take some time...

Regards,
Andre.


-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy