All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH #upstrema-fixes] libata: fix IDENTIFY order in ata_bus_probe()
Date: Fri, 04 Apr 2008 02:46:48 -0400	[thread overview]
Message-ID: <47F5CED8.6010900@garzik.org> (raw)
In-Reply-To: <47F2E2D3.6050100@gmail.com>

Tejun Heo wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> 
> Commit f58229f8060055b08b34008ea08f31de1e2f003c accidentally made
> ata_bus_probe() not use reverse order probing.  Fix it.
> 
> There currently isn't any PATA driver which uses obsolete
> ata_bus_probe() path, so this patch is mainly for correctness.
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-core.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 4851988..2db5c9c 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2660,7 +2660,7 @@ int ata_bus_probe(struct ata_port *ap)
>        specific sequence bass-ackwards so that PDIAG- is released by
>        the slave device */
> 
> -    ata_link_for_each_dev(dev, &ap->link) {
> +    ata_link_for_each_dev_reverse(dev, &ap->link) {
>         if (tries[dev->devno])
>             dev->class = classes[dev->devno];
> 

applied



      reply	other threads:[~2008-04-04  6:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-02  1:35 [PATCH #upstrema-fixes] libata: fix IDENTIFY order in ata_bus_probe() Tejun Heo
2008-04-04  6:46 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F5CED8.6010900@garzik.org \
    --to=jeff@garzik.org \
    --cc=bzolnier@gmail.com \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.