From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH #upstream] pata_scc: fix compile warning
Date: Fri, 04 Apr 2008 03:40:28 -0400 [thread overview]
Message-ID: <47F5DB6C.8060801@garzik.org> (raw)
In-Reply-To: <47EB7A88.6090004@gmail.com>
Tejun Heo wrote:
> Missed one during mass conversion (dc14c0c5). Fix it. Spotted by
> Stephen Rothwell.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> Stephen Rothwell wrote:
>> Hi Jeff, Tejun (Heo? I am sorry if I chose the wrong name),
>
> Yeap, Tejun is fine.
>
>> Today's build of linux-next produces this warning:
>>
>> drivers/ata/pata_scc.c:1002: warning: initialization discards
>> qualifiers from pointer target type
>>
>> Presumably caused by commit dc14c0c5012855bfc9a5f76056b92f198d52834c
>> ("libata: implement and use ops inheritance").
>
> Thanks for spotting this. I couldn't compile test platform specific
> ones. Hmm... pata_scc doesn't seem to have platform dependencies,
> maybe we can drop PPC_CELLEB dependency.
>
> drivers/ata/pata_scc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_scc.c b/drivers/ata/pata_scc.c
> index 07f2d7a..f6a6ce1 100644
> --- a/drivers/ata/pata_scc.c
> +++ b/drivers/ata/pata_scc.c
> @@ -960,7 +960,7 @@ static struct scsi_host_template scc_sht = {
> ATA_BMDMA_SHT(DRV_NAME),
> };
>
> -static const struct ata_port_operations scc_pata_ops = {
> +static struct ata_port_operations scc_pata_ops = {
> .inherits = &ata_bmdma_port_ops,
>
applied
prev parent reply other threads:[~2008-04-04 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080327151331.e11d3665.sfr@canb.auug.org.au>
2008-03-27 10:44 ` [PATCH #upstream] pata_scc: fix compile warning Tejun Heo
2008-04-04 7:40 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F5DB6C.8060801@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.