All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: lists@andyfurniss.entadsl.com
Cc: Corey Hickey <bugfood-ml@fatooh.org>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [NET_SCHED 00/04]: External SFQ classifiers/flow classifier
Date: Fri, 04 Apr 2008 12:45:44 +0200	[thread overview]
Message-ID: <47F606D8.108@trash.net> (raw)
In-Reply-To: <47F6062E.9050804@andyfurniss.entadsl.com>

Andy Furniss wrote:
> Andy Furniss wrote:
> 
>> OK - FWIW I've been looking harder and have now seen the full range of 
>> +/- 32k so I assume it's just not getting initialised properly.
> 
> Hmm I am not so sure now maybe it's a stats thing - I have seen flows 
> apparently stuck with -ve allot but behaving normally.
> 
> I notice allot is short (16bits?) in sfq but see
> 
> +struct tc_sfq_xstats
> +{
> +    __s32        allot;
> +};

That doesn't matter, its promoted to a 32 bit value. But now
that you mention it, the SFQ patch for iproute I submitted
used a different type. Stephen has resynced it with the kernel
in the mean time, but you might be using the broken version.



  reply	other threads:[~2008-04-04 10:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-31 17:58 [NET_SCHED 00/04]: External SFQ classifiers/flow classifier Patrick McHardy
2008-01-31 17:58 ` [NET_SCHED 01/04]: Constify struct tcf_ext_map Patrick McHardy
2008-01-31 17:58 ` [NET_SCHED 02/04]: sch_sfq: add support for external classifiers Patrick McHardy
2008-01-31 17:58 ` [NET_SCHED 03/04]: sch_sfq: make internal queues visible as classes Patrick McHardy
2008-01-31 17:58 ` [NET_SCHED 04/04]: Add flow classifier Patrick McHardy
2008-02-01  2:37 ` [NET_SCHED 00/04]: External SFQ classifiers/flow classifier David Miller
2008-02-02 23:23 ` Corey Hickey
2008-02-04 17:48   ` Patrick McHardy
2008-02-04 18:25     ` Corey Hickey
2008-03-29 23:35     ` Andy Furniss
2008-04-01 12:39       ` Patrick McHardy
2008-04-01 19:04         ` Andy Furniss
2008-04-02 11:42           ` Andy Furniss
2008-04-02 12:37             ` Patrick McHardy
2008-04-02 16:26               ` Andy Furniss
2008-04-04 10:42                 ` Andy Furniss
2008-04-04 10:45                   ` Patrick McHardy [this message]
2008-04-04 17:01                     ` Andy Furniss
2008-04-04 18:54                       ` Andy Furniss
2008-04-07 13:43                         ` Andy Furniss
2008-04-07 13:44                           ` Patrick McHardy
2008-04-07 15:14                             ` Andy Furniss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F606D8.108@trash.net \
    --to=kaber@trash.net \
    --cc=bugfood-ml@fatooh.org \
    --cc=lists@andyfurniss.entadsl.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.