From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Fix vmmouse with -smp Date: Sat, 05 Apr 2008 00:22:45 +0300 Message-ID: <47F69C25.9050901@qumranet.com> References: <1207265836-12156-1-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org To: Anthony Liguori Return-path: In-Reply-To: <1207265836-12156-1-git-send-email-aliguori@us.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > The vmport code is very broken for SMP guests. It uses a global CPUState > that's initialized multiple times? At any rate, since it needs to know CPU > registers for the current CPU in a PIO handler, it needs to use cpu_single_env. > > This patch makes vmmouse when using -smp > 1 > > Applied to kvm's qemu, thanks. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JhtNy-0002XV-9j for qemu-devel@nongnu.org; Fri, 04 Apr 2008 17:23:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JhtNw-0002XJ-Qe for qemu-devel@nongnu.org; Fri, 04 Apr 2008 17:23:44 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JhtNw-0002XG-LH for qemu-devel@nongnu.org; Fri, 04 Apr 2008 17:23:44 -0400 Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194] helo=il.qumranet.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JhtNw-0007Hi-8x for qemu-devel@nongnu.org; Fri, 04 Apr 2008 17:23:44 -0400 Message-ID: <47F69C25.9050901@qumranet.com> Date: Sat, 05 Apr 2008 00:22:45 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1207265836-12156-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1207265836-12156-1-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [kvm-devel] [PATCH] Fix vmmouse with -smp Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org Anthony Liguori wrote: > The vmport code is very broken for SMP guests. It uses a global CPUState > that's initialized multiple times? At any rate, since it needs to know CPU > registers for the current CPU in a PIO handler, it needs to use cpu_single_env. > > This patch makes vmmouse when using -smp > 1 > > Applied to kvm's qemu, thanks. -- Any sufficiently difficult bug is indistinguishable from a feature.