All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: fedora-kernel-list@redhat.com, video4linux-list@redhat.com,
	spca50x-devs@lists.sourceforge.net
Subject: Re: [New Driver]: usbvideo2 webcam core + pac207 driver using it.
Date: Sat, 05 Apr 2008 09:36:52 +0200	[thread overview]
Message-ID: <47F72C14.9080004@hhs.nl> (raw)
In-Reply-To: <20080404144935.3b457c69.zaitcev@redhat.com>

Pete Zaitcev wrote:
>>> #define CLIP(color) (unsigned char)(((color)>0xFF)?0xff:(((color)<0)?0:(color)))
>> Add a comment about what this is doing?  Could you just do it as a
>> static function instead?
> 
> The macro itself is too trivial to be commented, IMHO, but I have
> to ask just what it is doing there. It is only applied to
> precomputed values from pac207_decompress_table, as far as I see.
> So, they cannot be out of range. Or can they?
> 

Its being applied to the addition of a value read from the sensor and a 
precomputed value from the pac207_decompress_table, and the total of these can 
be out of range.

Regards,

Hans

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  parent reply	other threads:[~2008-04-05  7:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-28 21:53 [New Driver]: usbvideo2 webcam core + pac207 driver using it Hans de Goede
2008-04-03 21:27 ` Brandon Philips
2008-04-04  7:00   ` Hans de Goede
2008-04-04 18:56     ` Brandon Philips
     [not found]   ` <20080404144935.3b457c69.zaitcev@redhat.com>
2008-04-05  7:36     ` Hans de Goede [this message]
     [not found] ` <20080404184855.963369c5.zaitcev@redhat.com>
2008-04-05  7:52   ` Hans de Goede
  -- strict thread matches above, loose matches on Subject: below --
2008-03-28 21:52 Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F72C14.9080004@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=fedora-kernel-list@redhat.com \
    --cc=spca50x-devs@lists.sourceforge.net \
    --cc=video4linux-list@redhat.com \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.