From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ji6hX-0003W1-58 for mharc-grub-devel@gnu.org; Sat, 05 Apr 2008 07:36:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ji6hV-0003Va-5j for grub-devel@gnu.org; Sat, 05 Apr 2008 07:36:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ji6hS-0003Uu-QT for grub-devel@gnu.org; Sat, 05 Apr 2008 07:36:47 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ji6hS-0003Uq-HQ for grub-devel@gnu.org; Sat, 05 Apr 2008 07:36:46 -0400 Received: from mailout02.t-online.de ([194.25.134.17]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ji6hR-0007BX-P3 for grub-devel@gnu.org; Sat, 05 Apr 2008 07:36:46 -0400 Received: from fwd32.aul.t-online.de by mailout02.sul.t-online.de with smtp id 1Ji6hP-0003kl-00; Sat, 05 Apr 2008 13:36:43 +0200 Received: from [10.3.2.2] (Ze57FEZLwhLKuFvA6tzyR74mKDnACMW3mSkGxVrxcbhnQ+XdCW9tVFzjGIBd2gswlX@[217.235.250.143]) by fwd32.aul.t-online.de with esmtp id 1Ji6hC-1iv00e0; Sat, 5 Apr 2008 13:36:30 +0200 Message-ID: <47F7643D.2070204@t-online.de> Date: Sat, 05 Apr 2008 13:36:29 +0200 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071128 SeaMonkey/1.1.7 MIME-Version: 1.0 To: grub-devel@gnu.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: Ze57FEZLwhLKuFvA6tzyR74mKDnACMW3mSkGxVrxcbhnQ+XdCW9tVFzjGIBd2gswlX X-TOI-MSGID: 09abf65e-dabc-4b60-9a38-425a41604de8 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Infinite loop regression due to recent change in hostfs.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Apr 2008 11:36:49 -0000 Pavel Roskin wrote: > ... > Log message: > 2008-03-30 Pavel Roskin <...> > > * disk/host.c: Include grub/misc.h to fix a warning. > * util/hostfs.c: Use GRUB_MOD_INIT and GRUB_MOD_FINI to fix > warnings about implicit declarations. > > CVSWeb URLs: > http://cvs.savannah.gnu.org/viewcvs/grub2/ChangeLog?cvsroot=grub&r1=1.618&r2=1.619 > http://cvs.savannah.gnu.org/viewcvs/grub2/disk/host.c?cvsroot=grub&r1=1.2&r2=1.3 > http://cvs.savannah.gnu.org/viewcvs/grub2/util/hostfs.c?cvsroot=grub&r1=1.4&r2=1.5 The change in hostfs.c introduces an interesting regression: hostfs now appears in *_init.lst and grub_hostfs_init() is called twice in grub-emu and grub-fstest. This results in a infinite loop because the hostfs entry of grub_fs_list points to itself. Demo version :-) $ grub-fstest -d all /dev/sdX ls -l | grep Detecting | head -10000 | uniq -c You should either undo this change or remove extra calls to grub_hostfs_init/fini from grub-emu.c and grub-fstest.c. The latter might not work if it is necessary to init hostfs first for some reason. Christian